Repository navigation
docs(lessons): annotate a global with const and a local with let - #5364
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
⛔ Files ignored due to path filters: 9
📒 Files selected for processing: 73
✨ Finishing Touches
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
The "Annotating Variable Types" example showed two bare top-level `let` lines right after the Variables section teaches `const` at file scope and `let` inside a function. Copied as written, it is now the "global variables are declared with `const`" error. Show the annotation on a `const` global and on a `let` local inside a function. Follow-up to #5325, from CodeRabbit's review of it. Co-Authored-By: Claude Opus 5.5 <[email protected]>
rossirpaulo
force-pushed
the
paulo/lesson-typed-variables
branch
from
October 21, 2026 22:08
b40ce46 to
8310bfa
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #5325, addressing CodeRabbit's review of it (an "outside diff range" note on
typescript2/app-website/lessons/everything.md).The lesson's Variables section now teaches
constfor a global at file scope andletfor a local inside a function. The "Annotating Variable Types" example right after it still showed two bare top-levelletlines, which contradicts that and, copied as written, gives the new "global variables are declared withconst" error. It now shows the annotation on aconstglobal and on aletlocal inside a function:Only this example changes. The lesson's other bare
letsnippets are fragments illustrating arrays, maps and loops rather than declarations, so they're left as they are.Notes
const) #5325 and feat(reflect): list and look up a package's globals #5361 have merged; this PR is based oncanary.🤖 Generated with Claude Code