Repository navigation
fix(csharp): repair release ABI verification and prepare 0.22.2 - #5239
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 15.79% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 19 functions across 14 files. (9 skipped:… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly summarizes both main changes: repairing C# release ABI verification and preparing version 0.22.2.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 15.79% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 19 functions across 14 files. (9 skipped: 9 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 2
-
📝 Generate docstrings 💡
-
- Commit to this branch
- Create a new PR
🛠️ Fix failing CI checks 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
A rabbit checks the version line,
Then hops through probes in measured time.
New call fields join the ABI,
Release and cancel tests reply.
The bridge now wears a newer sign.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Binary size checks failed❌ 2 violations · ✅ 1 passed
Details & how to fixViolations:
Add/update baselines:
[artifacts.bridge_wasm]
file_bytes = 25820103
gzip_bytes = 7575609
[artifacts.packed-program]
file_bytes = 39246816
gzip_bytes = 16039578Generated by |
The 0.22.1 release fails C# artifact verification because
AbiLifetimeProbestill expects ABI 2 and the old invocation/cancellation behavior. Update it to ABI 4, send the required invocation envelope, release unused call allocations, and test cancellation through the existingthrows_test.SleepMsfixture. Cancellation assertions now requirebaml.panics.Cancelled, so an unknown function or malformed invocation cannot pass as cancellation.Run the same lifetime probe in the normal C# SDK suite on PRs, with bytecode and the native library built from that source. Keep the packaged release gate and its buffer/handle ownership checks. This addresses the stale-probe failure also discussed in #5146 while retaining verification coverage.
Bump the language and SDK release metadata to 0.22.2, regenerate the Node bridge, and refresh the Cargo/Python lockfiles. The wrapper stays at 0.2.5. A new patch is required because 0.22.1's packages and channel manifest were already published. After merge, successful post-merge CI triggers the canary release.
Validation: reproduced the original failure against the exact 0.22.1 release artifacts, then passed the repaired probe against those artifacts on macOS arm64. All 23 release-script tests, release-version consistency, and the eight-platform C# release contract pass. The full local C# SDK suite passes against the 0.22.2 source at this PR commit: 16 passed, including the new release ABI test, with one existing skipped test. Normal commit hooks, including formatting and workspace Clippy, pass.
Summary by CodeRabbit