Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e61051986a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
a0d7440 to
9aae3a0
Compare
9aae3a0 to
07de3c2
Compare
ec43556 to
c530262
Compare
07de3c2 to
1ad33ad
Compare
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
|
Found 4 test failures on Blacksmith runners: Failures
|
Binary size checks failed❌ 2 violations · ✅ 1 passed
Details & how to fixViolations:
Add/update baselines:
[artifacts.bridge_wasm]
file_bytes = 28679122
gzip_bytes = 7974453
[artifacts.packed-program]
file_bytes = 40767288
gzip_bytes = 16082158Generated by |
Makes v1 reliability policies select providers at the same wire boundary as v0: typed HTTP deadlines and explicit stream failures can retry/fall back even after a visible prefix. A reset event discards the failed attempt’s accumulated text, metadata and parser state, so the final result contains only the selected attempt.
Successful wire responses stop provider fallback before parsing and finish-reason filtering. Schema correction defaults to one attempt, graceful EOF after a decoded text or metadata event accepts partial output, and max-token termination is accepted by default. Agent and typed streaming runners expose explicit finish-reason allow/deny policies. Cancellation and unsafe tool effects remain non-recoverable.
Converts the nine v0-parity expected failures into passing assertions and adds deadline exhaustion, nested recovery, idle-after-prefix, metadata reset and finish-policy ordering coverage. Depends on the duration-valued HTTP options in #5054; stacked using
gh stack.Validation: all 50 focused reliability tests passed; the full native corpus passed 4,984 tests with 2 intentionally tolerated failures before the final finish-policy ordering fix; compiler snapshots, formatter, CLI builtin listing and changed-file pre-commit hooks passed on the final source. Broad Rust tests and GitHub CI are running.