Repository navigation
revert: remove unknown companion surface (#4464) - #4469
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (7)
📒 Files selected for processing (9)
💤 Files with no reviewable changes (8)
Included review availability: Your plan includes up to 8 reviews per rolling hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe change removes the builtin ChangesUnknown instance access removal
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to The PR restores the prior Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Binary size checks passed✅ 7 passed
Generated by |
sxlijin
added a commit
to ryanmazzolini/baml
that referenced
this pull request
Aug 17, 2026
## Summary - bump all legacy BAML v0 release surfaces from 0.225.0 to 0.226.0 using the repository version-bump configuration - add exactly the two verified external-contributor engine changes: connection pooling from BoundaryML#3975 and OpenAI transcriptions from BoundaryML#4202 - synchronize the new 0.226.0 sections in the top-level and Fern changelogs - regenerate all nine integration clients without test-report churn and update the engine, Rust SDK, and generated Rust integration lockfile versions ## Release boundary - 0.225.0 boundary: release PR BoundaryML#4310 / merge commit da2a673 - BoundaryML#3975 shipped as 521919c - BoundaryML#4202 merged from reviewed head ff96fd4 as squash commit 79b8705; the reviewed-head and squash diffs have the same stable patch ID - BoundaryML#4464 and its byte-perfect revert BoundaryML#4469 have zero net diff and are excluded - rebased onto current canary after BoundaryML#4202 merged ## Validation - TypeScript runtime build and nine-client generation - Python runtime build/install and nine-client generation - deterministic regeneration: unchanged binary diff hash on repeated generation - locked Cargo metadata for the engine and Rust SDK workspaces - generated Rust integration library build: `cargo test --lib --locked` - OpenAI transcription wiremock closure tests: 2 passed - generated Python multipart request test: 1 passed - connection pooling transport test: 1 passed - HTTP config validation fixtures: 8 passed - release metadata and workflow contracts: 50 passed - stale 0.225.0 audit clean across release-owned surfaces; historical junit.xml intentionally unchanged - final release diff matches the 0.225.0 workflow-owned file set, excludes junit.xml test-report churn, and additionally refreshes the two tracked Rust SDK/integration lockfiles proven stale by locked builds ## Status - dependency satisfied; rebased onto current canary with the reviewed BoundaryML#4202 patch present - all required GitHub Actions checks are green; local and GitHub CodeRabbit reviews are green with approval and no review threads or requested changes - merge-ready; awaiting normal human review
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Byte-perfect revert of #4464's `baml.Unknown` companion: `unknown` returns to having no member surface, and runtime field reads return to the free-function spelling `reflect.class.get_field(obj, name)`.
Split out of #4466 at Antonio's direction: this revert half merges now; the replacement value-side API (`reflect.class.instance_from`) stays on #4466 for explicit human sign-off.
Verification
Notes
Summary by CodeRabbit
Breaking Changes
Unknownbuilt-in type and its instance-based field access method.Changes