Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdds an end-to-end regression test for a test named ChangesSlash-Preserving Test Names
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: 🔵 Low · up to This PR adds CLI regression coverage for preserving literal slashes in test names without changing shipped runtime behavior. The targeted integration test could not run because the build environment could not execute the C compiler, so it should be rerun in a working environment before treating validation as complete. Possibly related PRs
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
Binary size checks passed✅ 7 passed
Generated by |
Summary
alpha/beta gammatest namebaml test --listpreserves the literal slash in the canonical IDPASSoutput preserves the literal slash and never renders it as::Context
The historical renderer split test paths on
/, which made a user-provided slash look like the::hierarchy separator. The canonical-ID path oncanarynow carries the complete test ID through rendering without splitting on/; this test locks that behavior at the CLI boundary.Validation
cargo test -p baml_cli --test exit_code_e2e test_slash_in_name_is_rendered_verbatim -- --nocapturecargo test -p baml_cli --test test_profiles_e2e failed_expansion_is_not_cached_and_literal_slash_selector_is_legal -- --nocapturecargo fmt --check --package baml_cligit diff --checkSummary by CodeRabbit
/appear verbatim when listing tests and in execution results.