Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Binary size checks passed✅ 7 passed
Generated by |
4e79a13 to
9070cbc
Compare
9070cbc to
6c761d5
Compare
This comment has been minimized.
This comment has been minimized.
6c761d5 to
52aca0a
Compare
52aca0a to
4fef9fe
Compare
4fef9fe to
e793c8d
Compare
e793c8d to
785d799
Compare
785d799 to
aed372d
Compare
aed372d to
17b3089
Compare
Three spellings described the same Python target: `baml.toml` wanted `python/pydantic`, `baml generate add` wanted `python/pydantic2`, and the enum carried a `PythonPydanticV1` variant. Collapse them to one. `add_name()` is gone. `Display` now produces the canonical name that gets written to `baml.toml`, `FromStr` reads every canonical name back, and `canonical()` is the same string with a `'static` lifetime for clap's `PossibleValue`. A test asserts the two agree and that every canonical name round-trips, since a name `Display` writes but `FromStr` cannot read would silently corrupt the manifest. `python` and `typescript` are accepted as aliases for the canonical Python and Node targets. They parse but are hidden from the possible-values list, so that list names exactly what lands in `baml.toml`; the argument's help text names the aliases instead. `OutputType::PythonPydanticV1` is deleted. It shared a dispatch arm with `PythonPydantic` and passed identical arguments, so the v1 spelling silently emitted Pydantic v2 code. Nothing else in the tree referenced it. It is now an unknown value with clap's did-you-mean suggestion, which is strictly better than wrong output. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_018Jm6FCeSHxhtM2S6oTQR5B
17b3089 to
b734c62
Compare
Three spellings described the same Python target:
baml.tomlwantedpython/pydantic,baml generate addwantedpython/pydantic2, and the enum carried aPythonPydanticV1variant. This collapses them to one.add_name()is gone.Displaynow produces the canonical name written tobaml.toml,FromStrreads every canonical name back, andcanonical()is the same string with a'staticlifetime for clap'sPossibleValue. Tests assert the two agree and that every canonical name round-trips — a nameDisplaywrites butFromStrcannot read would silently corrupt the manifest.pythonandtypescriptare accepted as aliases for the canonical Python and Node targets. They parse but are hidden from the possible-values list, so that list names exactly what lands inbaml.toml; the argument's help text names the aliases instead.OutputType::PythonPydanticV1is deleted. It shared a dispatch arm withPythonPydanticand passed identical arguments, so the v1 spelling silently emitted Pydantic v2 code. Nothing else in the tree referenced it. It is now an unknown value with clap's did-you-mean suggestion, which is strictly better than wrong output.Second of three stacked PRs for B-1145. Based on #4392 — review that first. Next: #4394
🤖 Generated with Claude Code
https://claude.ai/code/session_018Jm6FCeSHxhtM2S6oTQR5B