Repository navigation
chore: minimize mise tools for pre-commit checks - #4384
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Mise environment pins ChangesUnified Mise CI setup
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to The PR makes CI tool installation explicit and pins clang-format for more predictable checks; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yaml:
- Around line 455-457: Restore the job-specific install_args for every listed
mise-action site: in .github/workflows/ci.yaml at 455-457, 832-834, and 931-933
use cargo:prek python uv node clang-format, node npm:pnpm protoc protoc-gen-go,
and ast-grep respectively; in .github/workflows/cargo-tests.reusable.yaml at
87-89, 189-191, 284-286, 384-386, 856-858, 1070-1072, 1173-1175, and 1249-1251
restore sccache direnv cargo:cargo-nextest, the applicable matrix.install-args,
sccache direnv, and snapshot-specific sccache direnv python uv cargo:cargo-insta
cargo:cargo-nextest values; restore sccache direnv or sccache direnv clang in
.github/workflows/size-gate.reusable.yaml at 61-63, 146-148, 235-237, 337-339,
and 436-438; and restore github:rustwasm/wasm-pack in
.github/workflows/wasm-pack-tests.reusable.yaml:68-70 and
.github/workflows/webview-tests.reusable.yaml:51-53, 106-108, and 151-153.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 931892e2-dbff-4d3c-8be0-486c54baeaf5
📒 Files selected for processing (5)
.github/workflows/cargo-tests.reusable.yaml.github/workflows/ci.yaml.github/workflows/size-gate.reusable.yaml.github/workflows/wasm-pack-tests.reusable.yaml.github/workflows/webview-tests.reusable.yaml
Binary size checks passed✅ 7 passed
Generated by |
Summary
./.github/actions/setup-misecomposite and its narrow per-jobinstall_argsjdx/[email protected]invocation withfetch_from_github: falseMISE_TASK_RUN_AUTO_INSTALL=falseto$GITHUB_ENV, preventing every subsequent CI step from auto-installing undeclared mise toolsclang-formatso the C++ formatting hook does not depend on the runner imageRoot cause
The pre-commit hooks invoke tasks through
mise run. Mise auto-installs configured tools before running tasks by default, andjdx/mise-actionexportsMISE_YES=1. As a result, the first task invocation tried to install the entire inherited rootmise.tomltoolset even though setup used narrowinstall_args. External GitHub 503s for unrelated sccache, Java, and Ruby then failed the job after all hooks had passed.The fix preserves narrow tool installation through the shared composite and disables mise task auto-install globally for all steps after setup-mise. This makes each workflow's
install_argsthe explicit tool contract instead of allowing latermise runcalls to expand it implicitly.Validation
./.github/actions/setup-misewith their priorinstall_argsjdx/[email protected]call setsfetch_from_github: falsedisabling MISE_TASK_RUN_AUTO_INSTALL, all CI workflows must explicitly install the mise deps they useMISE_TASK_RUN_AUTO_INSTALL=falseto$GITHUB_ENVcheck-yamlhook passed the composite action and affected workflowpython3 -m unittest discover -s scripts/tests -p 'test_*.py' -vpassed all 49 testsgit diff --checkpassedactionlintreported no new errors; its three warnings are pre-existing inci.yamlLinear: B-1522
Source failure: https://github.com/BoundaryML/baml/actions/runs/31635586472/job/94250484725?pr=3358
Summary by CodeRabbit
clang-formatto the development tool environment.clang-format.