Repository navigation
feat(web): techdocs coming-soon title, quickstart flex-column spacing - #4353
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Opus 4.7 <[email protected]>
Co-Authored-By: Claude Opus 4.7 <[email protected]>
# Conflicts: # .vscode/settings.json # pnpm-lock.yaml # typescript2/pnpm-lock.yaml
Replaces the inline ~870-LOC BamlPlayground hero embed with a worker-hosted
runtime + ExecutionPanel from @b/pkg-playground (matching the pattern in
app-promptfiddle). Picks up the Run/Graph/Prompt/cURL tabs, function/test
sidebar, pluggable result renderers, and the API-keys dialog for free.
- Worker (app-website/playground/baml-worker.ts): adapts promptfiddle's
worker minus the LSP MessagePort path; the website doesn't host Monaco,
so the runtime LSP handshake is driven directly. Stubs input/exec/shell
callbacks (canary additions for read_input + shell stdlib) so they fail
fast — the marketing playground intentionally doesn't expose them.
- BamlPlayground.tsx (~150 LOC): spawns the worker, waits for ready,
wraps in WorkerRuntimePort, hands to <ExecutionPanel>. Auto-respawns
the worker on error so a runtime panic doesn't kill the page; ExecutionPanel
remounts cleanly via connectionVersion. Debounces filesChanged 200ms to
coalesce keystrokes.
- BamlEditor.tsx: simplified to read-only Shiki-highlighted view by default
with a floating "Remove Training Wheels" toggle to enable the full
textarea-overlay edit mode. Drops the inline editable-region machinery.
- Hero (variant-home.tsx): inline expanded playground for desktop only
(lg+); mobile shows a static screenshot CTA so phones don't ship the
worker + WASM + ELKjs bundle.
- Replaces local proto/{encode,decode,types,generated} with @b/pkg-proto.
- Replaces gitignored public/wasm/* with workspace @b/bridge_wasm link.
- Drops EditorTerminalSplit + PlaygroundTerminal (no longer used).
- Globals.css: registers vsc-* Tailwind tokens and a .baml-playground-root
scope that overrides shadcn tokens to dark values for the playground
subtree only — no theme bleed into the cream marketing site.
pkg-playground tweaks:
- Add 'use client' at the index entry (Next 15 RSC compat).
- ExecutionPanel: fix sub-function call separator (`Fn.render_prompt` →
`Fn$render_prompt`) so the Prompt/cURL tabs hit the actual runtime names.
- Add initialArgsJson prop so consumers can pre-fill the args input.
- Update worker-protocol doc to reflect $ separator.
Notes:
- Default BAML uses new-style `test "name" { Fn(...) }` blocks; old-style
`test Name { functions [...] args {...} }` parses but the runtime never
registers them into $init_test_<file_id>, so collection returns Null.
- @b/bridge_wasm is rebuilt from baml_language/crates/bridge_wasm and
picks up the canary fix for collect_tests returning BexExternalValue::Null
(no-tests case) cleanly instead of corrupting WASM memory.
`pnpm install` reconciles the lockfile against the package.json updates brought in by the canary merge (nodemon, just-bash, vitest, jotai in pkg-playground deps) plus the website's new @b/pkg-playground / @b/pkg-proto / @b/bridge_wasm workspace deps.
Observability moves to section 1 and gets a new graphic: two ripple fields side by side (OTEL forgets each pass, BAML keeps the light) with a live event feed under each. The two-axis matrix placeholder is parked, read-mores flow inline in prose (or bottom-right inside the explorer card), dividers get an even rhythm, the company logo row lands under the borrowed-traits list, and the rebus caption drops monospace and reveals sooner. Co-Authored-By: Claude Fable 5 <[email protected]>
/ now renders the what-is-baml page; /what-is-baml and /explore both redirect home, and the old explore article stays reachable at /explore-legacy. The homepage tab title becomes 'Basically a Made-up Language' and the site-wide default titles drop the em dash. Co-Authored-By: Claude Fable 5 <[email protected]>
The install unit's prose, tabs, and prompt move to the body font (shell command lines stay mono), and the 'paste into your favorite coding agent' lead is gone. In the shared CTA styles a selector meant for the button icons was crushing the buttons themselves, hiding the 'Book a session' label; it now targets the svgs, and the primary button colors carry enough specificity to survive page-level link rules. Footer tagline becomes 'Basically a made up language.' Co-Authored-By: Claude Fable 5 <[email protected]>
Every homepage read-more points at /techdocs, a short human-written note about the upcoming deep-dive articles. Quickstart tightens its heading rhythm, un-bolds the lead, and lets the install unit span the column so it lines up with the cards; /eap collapses to one 800px column so the header, text, and cards share edges. Co-Authored-By: Claude Fable 5 <[email protected]>
Removes the "used by some of the world's largest companies" line and the Google/AWS/SAP marks under it, plus the .wib-users styles that only served that row. The logo assets stay, since company-showcase and variant-home still use them. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
Address the PR review: the expanded playground gains Escape dismissal, dialog semantics, and a background scroll lock, and is hidden entirely on touch/small screens; the explorer tabs get the tabpanel wiring their ARIA roles promised; the pack size table moves under Ship Anywhere where its content belongs; the acquirer cycler clears its inner fade timeout on unmount; the dropped counter formats with toLocaleString like its sibling; and the agent-tries-baml read-more label becomes prose. Co-Authored-By: Claude Fable 5 <[email protected]>
The Biome CI job lints every file the PR touches against the stricter typescript2 config, which this branch's files had never been held to. Rename TryBaml/BamlEditor/Story to kebab-case and update importers, apply the sorted-keys/attributes and organize-imports fixes across the touched learn decks and editor, fix the real findings (unused webpack param and parked posthog import in next.config, assign-in-expression and at(-1) in the editor, descending specificity in the install unit's css, aria-label without a role on the rebus), and add reasoned suppressions where the pattern is deliberate (static <img> marks, static page CSS injection, effect dependency choices). Co-Authored-By: Claude Fable 5 <[email protected]>
… gate The deck entered the lint set via the baml-editor-lazy import rename; this is the same autofix pass the learn3 deck already got.
The renamed baml-editor-lazy imports use the @/app alias instead of deep relative paths, and the Try BAML compact variant no longer copies the editor-setup command it does not show.
…a flex column The quickstart page becomes one flex column with a uniform 44px gap and zeroed child margins, so section spacing cannot collapse or compound; headings pair with their content in small section groups (Handy links with its card grid, Keeping BAML updated with its note). The techdocs page heading becomes Tech Docs Coming Soon.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Quickstart page now uses section wrappers and explicit flex spacing. Its card grid gap increases from 10px to 12px. The Tech Docs heading changes to “Tech Docs Coming Soon.” ChangesWebsite page updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
typescript2/app-website/app/quickstart/page.tsx (1)
64-71: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueUse single quotes for changed JSX attribute values.
Replace the changed double-quoted JSX attributes with single-quoted attributes. As per coding guidelines,
typescript2/app-website/**/*.{ts,tsx}must use single quotes.Also applies to: 82-121
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@typescript2/app-website/app/quickstart/page.tsx` around lines 64 - 71, Update the changed JSX attributes in the Quickstart page, including the related section spanning the referenced range, to use single-quoted values instead of double quotes. Preserve the existing class names and JSX structure.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@typescript2/app-website/app/quickstart/page.tsx`:
- Around line 24-31: Update the quickstart CSS margin resets so all direct
children of the flex containers used by qs-head and qs-sec, including the h1 and
lead paragraph, have zero margins before gap controls spacing. Ensure the
existing .qs-wrap p margins do not override these direct-child resets,
preserving the intended 18px and 14px gaps.
---
Nitpick comments:
In `@typescript2/app-website/app/quickstart/page.tsx`:
- Around line 64-71: Update the changed JSX attributes in the Quickstart page,
including the related section spanning the referenced range, to use
single-quoted values instead of double quotes. Preserve the existing class names
and JSX structure.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: bdf05235-4c6e-4c62-8dce-06440c13d22b
📒 Files selected for processing (2)
typescript2/app-website/app/quickstart/page.tsxtypescript2/app-website/app/techdocs/page.tsx
.qs-wrap p was out-specifying the group resets, inflating the flex gaps; paragraph margins are now zero and the head/section groups reset their children explicitly.
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #4351, which merged just before this landed.
One commit, app-website only, lint and typecheck clean.
Summary by CodeRabbit
Style
Content