Repository navigation
fix(playground): hide default placeholders for explicit args - #4275
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes. 💤 Files selected but had no reviewable changes (1)
⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthrough
ChangesArgument placeholder update
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
…t-arg-placeholder # Conflicts: # issue-overview.md
Summary
Root cause
ArgsFormalways forwardedparam.defaultExpressionas the native input placeholder, regardless of whether the argument was using its default or had been checked for an explicit value. An empty explicit string therefore looked like the declared default would be sent.Playground UI
Before
After
Validation
pnpm exec biome check pkg-playground/src/ArgsForm.tsxpnpm --filter @b/pkg-playground typecheckpnpm --filter @b/pkg-playground test(145 tests)pnpm --filter app-vscode-webview typecheckpnpm --filter app-promptfiddle typecheckpnpm --filter app-vscode-webview test:unit:run -- ExecutionPanel.strict-mode.test.tsx(22 tests)git diff --checkLinear: https://linear.app/boundaryml2/issue/B-1061/default-arg-ui-when-default-args-are-checked-the-placeholder-in-the
Summary by CodeRabbit