Repository navigation
Fix Go release smoke dependency setup - #4233
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThe Go release smoke script now runs ChangesGo release dependency reconciliation
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/tests/test_release_pipeline_contract.py`:
- Around line 995-1002: Broaden
test_go_release_smoke_reconciles_complete_dependency_graph so it rejects any
module-specific go mod download invocation, regardless of formatting or variable
names. Replace the exact-string negative assertion with a command-prefix check
or parsed invocation validation, while retaining the existing go mod tidy
assertion.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 983bcc57-e957-4b0b-bae3-bad79383aa48
📒 Files selected for processing (2)
scripts/smoke-go-release.pyscripts/tests/test_release_pipeline_contract.py
Summary
go mod tidybefore testing itRoot cause
The smoke test hand-writes an exact
baml-gorequirement, then previously rango mod download github.com/boundaryml/baml-go@<version>. That command downloaded and authenticated only the named module. With Go's pruned module graph, the clean consumer still lacked the indirect protobuf requirement and checksums, sogo testfailed on every OS even though the publishedbaml-gomodule was valid.go mod tidyis the canonical minimal operation after client generation: it preserves the exact BAML version already pinned ingo.mod, reconciles transitive requirements, and populates the consumer'sgo.sum.Validation
python3 -m unittest scripts.tests.test_release_pipeline_contract— 22 tests passedgit diff --checkpassedscripts/smoke-go-release.pyend to end against public release0.15.1-nightly.20260727.f; it resolved the exact proxy module, compiled the generated client, downloaded the manifest-selected native runtime, verified its checksum, and completed the runtime call successfullySummary by CodeRabbit
Bug Fixes
Tests