Repository navigation
Allow immutable release tags to assume manifest role - #4223
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe release role now allows GitHub OIDC subjects for the canary branch and immutable source tags. The production release contract test loads the stack and verifies these allowlists, the OIDC condition, and rejection of broad wildcard ref permissions. ChangesRelease OIDC contract
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning Review ran into problems🔥 ProblemsGit: Failed to clone repository. Please run the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
Binary size checks passed✅ 7 passed
Generated by |
Summary
pkg.boundaryml.comGitHub OIDC role to trust immutablebaml-language-source-*release tagscanarysubject for canary dry-run uploadsRoot cause
Production releases are now dispatched from immutable source tags, but the IAM trust policy still accepted only
refs/heads/canary. AWS therefore rejected the manifest publisher withsts:AssumeRoleWithWebIdentity, which correctly prevented the dependent Go publication and channel promotion.Validation
mise exec -- python -m unittest scripts.tests.test_release_pipeline_contractmise exec -- pnpm run buildintools/pkg_boundaryml_commise exec -- pnpm exec cdk synth --jsonand exact synthesized-subject assertiongit diff --checkDeployment note
The CDK stack must be deployed after merge to update the live IAM role before the next release reaches the manifest publisher.
Summary by CodeRabbit
Security Enhancements
Tests