Repository navigation
Fix C# release scanner dependency - #4190
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe C# primitive consumer verification script now scans published files with recursive ChangesC# repository path scanning
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
Binary size checks passed✅ 7 passed
Generated by |
What changed
rgto recursive fixed-stringgrepRoot cause
The BAML Language Release package assembly runner does not install ripgrep. The older pipeline accidentally treated
rg: command not foundas a clean scan because the command was hidden inside anifpipeline. The fail-closed scanner introduced in #4184 correctly surfaced exit 127, but that causedVerify C# SDK product package / Assemble one provenance-bound packageto fail after the package had otherwise built and executed successfully.grepis already required and exercised earlier in the same consumer verifier, so this removes the undeclared cross-platform dependency without adding runner provisioning.Validation
linux-x64end to end with a PATH that contains norglinux-musl-x64in the pinned Alpine/.NET image with ripgrep deliberately absentprimitive_exact_package=okSummary by CodeRabbit
Bug Fixes
Tests