Repository navigation
Fix C# release plan schema contract - #4173
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughRelease tooling now requires release-plan schema 3. Contract tests generate plans through ChangesRelease plan schema contract
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
Binary size checks passed✅ 7 passed
Generated by |
What changed
scripts/baml-language-version.Root cause
The release-plan producer moved to schema 3 when NuGet, Maven, Gradle, SwiftPM, and deterministic
released_atmetadata were added. The C# verifier and its isolated fixture still required schema 2. Release package assembly therefore rejected the valid frozen plan before NuGet packaging, even after the LLVM tooling fix passed.Observed in release run 30066212741:
Impact
This restores the fail-closed producer/consumer contract without accepting obsolete schema-2 plans and unblocks C# product package verification and downstream NuGet publication.
Validation
python3 -m unittest scripts.tests.test_release_pipeline_contract scripts.tests.test_baml_language_versionSummary by CodeRabbit
Release Pipeline
Tests