Repository navigation
Conversation
…low-up) PR #4120 added verify-csharp-product-slice as a release gate, but its platform-contract assertions had nothing to read: release/platforms.json has no artifacts.csharp blocks, and the bridge-cffi producer never emitted the artifact-identity.txt the packager requires. Every release run since has failed at 'Compute product consumer matrix', which also blocks the pkg.boundaryml.com manifest publish — the nightly channel manifest has been frozen at 0.15.1-nightly.20260716.b while GitHub releases kept shipping. - release/platforms.json: add csharp {rid, native_asset, consumer_runner} to all eight targets (8 unique RIDs, 3 canonical native assets — libbridge_cffi.dylib/.so and bridge_cffi.dll — runners mirroring each target's existing toolchain runners). - build2-bridge-cffi.reusable.yaml: write a 6-line artifact-identity.txt (source_sha, workflow_run_id, workflow_run_attempt, release_version, target, asset) next to the cdylib and upload it, matching the verifier's exact-file-set and line-by-line provenance checks. Co-Authored-By: Claude Fable 5 <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
|
Do not merge Claude. Bad boy. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe release workflow now uploads an ChangesRelease artifacts
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
Since #4120 merged, every BAML Language Release run fails at
Verify C# SDK product package / Compute product consumer matrix, and because the manifest-publish job is downstream of that gate, the pkg.boundaryml.com channel manifests have been frozen at0.15.1-nightly.20260716.b—baml toolchain install nightlyresolves a week-stale toolchain everywhere (and no per-version manifest exists for anything newer, so pinning doesn't work either).Two gaps between #4120's verifier and what the repo/pipeline actually provide:
release/platforms.jsonhas noartifacts.csharpblocks, but the matrix derivation asserts 8 targets withcsharp+cffi, 8 unique RIDs, 3 canonical native assets, and 8 string runners →jq -eprintsfalseand the job exits 1.bridge-cffi-*producer uploads only the cdylib +.sha256, but the packager requires exactly 3 files per artifact including a 6-lineartifact-identity.txt(source_sha / workflow_run_id / workflow_run_attempt / release_version / target / asset) it verifies line-by-line.Fix
release/platforms.json: addcsharp: { rid, native_asset, consumer_runner }to all 8 targets. RIDs are the standard .NET RIDs (8 unique); canonical assets arelibbridge_cffi.dylib/libbridge_cffi.so/bridge_cffi.dll(3 unique, matching the pre-rename base names in the cffi build and the hard-codedlibbridge_cffi.soin the verify scripts); consumer runners mirror each target's existing toolchain runner.build2-bridge-cffi.reusable.yaml: emitartifact-identity.txtnext to the cdylib in the rename/checksum step and add it to the uploaded artifact.@rossirpaulo — please sanity-check the RID/runner choices against what
publish2-csharp-sdkexpects; happy to adjust.🤖 Generated with Claude Code
Summary by CodeRabbit
New Features
Improvements