Skip to content

Fix dynamic playground form state reconciliation #3972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rossirpaulo merged 2 commits into from
Jul 10, 2026
Merged

Fix dynamic playground form state reconciliation #3972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
756d703
fix playground dynamic form state reconciliation
rossirpaulo Jul 10, 2026
9c2033b
Merge branch 'canary' into paulo/fix-dynamic-form-state
rossirpaulo Jul 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
193 changes: 193 additions & 0 deletions typescript2/app-vscode-webview/src/ExecutionPanel.strict-mode.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,6 +328,199 @@ describe('ExecutionPanel args form', () => {
});
});

it('reconciles cached form values when a same-name function schema changes', async () => {
const port = new FakeRuntimePort();

render(<ExecutionPanel port={port} />);

act(() => {
port.emit({
type: 'playgroundNotification',
notification: { type: 'listProjects', projects: ['project'] },
});
port.emit({
type: 'playgroundNotification',
notification: {
type: 'updateProject',
project: 'project',
update: {
isBexCurrent: true,
functions: [
{
name: 'EchoPerson',
kind: 'expr',
origin: 'userDefined',
params: [
{
name: 'person',
hasDefault: false,
schema: { type: 'ref', name: 'user.Person' },
},
],
},
],
types: {
'user.Person': {
kind: 'class',
fields: [
{ name: 'name', schema: { type: 'string' } },
{ name: 'active', schema: { type: 'bool' } },
],
},
},
diagnostics: [],
},
},
});
});

fireEvent.click(
await screen.findByRole('button', { name: 'Functions (1)' }),
);
fireEvent.click(await screen.findByRole('button', { name: 'EchoPerson' }));
fireEvent.change(await screen.findByPlaceholderText('text'), {
target: { value: 'Ada' },
});

// Hot-reload the same function name with a new required class field.
act(() => {
port.emit({
type: 'playgroundNotification',
notification: {
type: 'updateProject',
project: 'project',
update: {
isBexCurrent: true,
functions: [
{
name: 'EchoPerson',
kind: 'expr',
origin: 'userDefined',
params: [
{
name: 'person',
hasDefault: false,
schema: { type: 'ref', name: 'user.Person' },
},
],
},
],
types: {
'user.Person': {
kind: 'class',
fields: [
{ name: 'name', schema: { type: 'string' } },
{ name: 'active', schema: { type: 'bool' } },
{ name: 'age', schema: { type: 'int' } },
],
},
},
diagnostics: [],
},
},
});
});

const ageInput = await screen.findByPlaceholderText('0');
await waitFor(() => {
expect(ageInput).toHaveValue('0');
expect(screen.getByPlaceholderText('text')).toHaveValue('Ada');
});
fireEvent.change(screen.getByPlaceholderText('text'), {
target: { value: 'Ada Lovelace' },
});

fireEvent.click(await screen.findByRole('button', { name: 'raw' }));
const rawInput = await screen.findByPlaceholderText('{"key": "value"}');
await waitFor(() => {
expect(JSON.parse((rawInput as HTMLInputElement).value)).toEqual({
person: {
$baml: { type: 'user.Person' },
name: 'Ada Lovelace',
active: false,
age: 0,
},
});
});
});

it('serializes untouched defaults inside a required nested class', async () => {
const port = new FakeRuntimePort();

render(<ExecutionPanel port={port} />);

act(() => {
port.emit({
type: 'playgroundNotification',
notification: { type: 'listProjects', projects: ['project'] },
});
port.emit({
type: 'playgroundNotification',
notification: {
type: 'updateProject',
project: 'project',
update: {
isBexCurrent: true,
functions: [
{
name: 'EchoEnvelope',
kind: 'expr',
origin: 'userDefined',
params: [
{
name: 'envelope',
hasDefault: false,
schema: { type: 'ref', name: 'user.Envelope' },
},
],
},
],
types: {
'user.Flag': {
kind: 'class',
fields: [{ name: 'active', schema: { type: 'bool' } }],
},
'user.Envelope': {
kind: 'class',
fields: [
{
name: 'flag',
schema: { type: 'ref', name: 'user.Flag' },
},
],
},
},
diagnostics: [],
},
},
});
});

fireEvent.click(
await screen.findByRole('button', { name: 'Functions (1)' }),
);
fireEvent.click(
await screen.findByRole('button', { name: 'EchoEnvelope' }),
);

// The switch is untouched and visually false; raw state must already
// contain that same false value rather than a marker-only nested class.
expect(await screen.findByRole('switch')).not.toBeChecked();
fireEvent.click(await screen.findByRole('button', { name: 'raw' }));
const rawInput = await screen.findByPlaceholderText('{"key": "value"}');
await waitFor(() => {
expect(JSON.parse((rawInput as HTMLInputElement).value)).toEqual({
envelope: {
$baml: { type: 'user.Envelope' },
flag: {
$baml: { type: 'user.Flag' },
active: false,
},
},
});
});
});

it('keeps an explicitly chosen union variant selected when values overlap', async () => {
const port = new FakeRuntimePort();

Expand Down
Loading
Loading