Repository navigation
chore(sdk): rename baml_core -> baml_bridge - #3934
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (38)
📒 Files selected for processing (120)
💤 Files with no reviewable changes (4)
✅ Files skipped from review due to trivial changes (51)
🚧 Files skipped from review as they are similar to previous changes (49)
📝 WalkthroughWalkthroughThis PR renames the runtime bridge package and its generated interfaces from Changesbaml_core → baml_bridge rename
Estimated code review effort: 4 (Complex) | ~45 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79ec83e569
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # TypeScript (ts-proto / buf) — typescript2/pkg-proto consumer | ||
| cd typescript2/pkg-proto && pnpm generate | ||
| # -> typescript2/pkg-proto/src/generated/baml_core/cffi/v1/*.ts | ||
| # -> typescript2/pkg-proto/src/generated/baml_bridge/cffi/v1/*.ts |
There was a problem hiding this comment.
With this regenerated path now under src/generated/baml_bridge/..., the TypeScript consumer no longer matches its generated output: I checked typescript2/pkg-proto/src/{types,decode,encode,index}.ts and the tests, and they still import ./generated/baml_core/.... After cd typescript2/pkg-proto && pnpm generate, pnpm run typecheck fails with missing generated/baml_core modules, so webview/playground builds that regenerate pkg-proto will break unless those imports are renamed alongside the proto package.
Useful? React with 👍 / 👎.
Binary size checks passed✅ 7 passed
Generated by |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
baml_language/sdks/python/rust/bridge_python/src/media.rs (1)
127-138: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick winMove the generated stub under
src/baml_bridge/
rust/bridge_python/src/baml_core/baml_py/__init__.pyistill reflects the old layout, whilepyproject.tomlandgenerate_stubs.pynow targetbaml_bridge.baml_pyundersrc/baml_bridge/. Keeping the stalebaml_corepath leaves the checked-in stubs out of sync.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@baml_language/sdks/python/rust/bridge_python/src/media.rs` around lines 127 - 138, The generated stub path is still using the old baml_core layout, so the checked-in Python stubs are out of sync with the new package location. Update the stub generation and committed stub target for the baml_bridge.baml_py package so the generated .pyi ends up under src/baml_bridge/ rather than baml_core, and verify the media pyclass/module naming stays aligned with the new import path in define_media_pyclass and generate_stubs.py.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Outside diff comments:
In `@baml_language/sdks/python/rust/bridge_python/src/media.rs`:
- Around line 127-138: The generated stub path is still using the old baml_core
layout, so the checked-in Python stubs are out of sync with the new package
location. Update the stub generation and committed stub target for the
baml_bridge.baml_py package so the generated .pyi ends up under src/baml_bridge/
rather than baml_core, and verify the media pyclass/module naming stays aligned
with the new import path in define_media_pyclass and generate_stubs.py.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: e6f7185c-8063-4970-9b9d-9279afc97550
⛔ Files ignored due to path filters (30)
baml_language/crates/baml_cli/src/snapshots/baml_cli__describe_command_tests__render_keyword_python.snapis excluded by!**/*.snapbaml_language/crates/baml_cli/src/snapshots/baml_cli__describe_command_tests__render_keyword_typescript.snapis excluded by!**/*.snapbaml_language/sdks/go/bridge_go/cffi/proto/baml_bridge/cffi/v1/baml_handle.pb.gois excluded by!**/*.pb.gobaml_language/sdks/go/bridge_go/cffi/proto/baml_bridge/cffi/v1/baml_inbound.pb.gois excluded by!**/*.pb.gobaml_language/sdks/go/bridge_go/cffi/proto/baml_bridge/cffi/v1/baml_outbound.pb.gois excluded by!**/*.pb.gobaml_language/sdks/go/bridge_go/cffi/proto/baml_bridge/cffi/v1/baml_type.pb.gois excluded by!**/*.pb.gobaml_language/sdks/nodejs/bridge_nodejs/dist/ctx_manager.d.tsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/ctx_manager.jsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/define_function.d.tsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/define_function.jsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/errors.jsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/exit_hook.d.tsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/exit_hook.jsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/host_value_registry.d.tsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/host_value_registry.jsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/index.d.tsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/index.jsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/native.d.tsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/native.jsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/proto.d.tsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/proto.jsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/proto/baml_cffi.d.tsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/proto/baml_cffi.jsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/stream.d.tsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/stream.jsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/typemap.d.tsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/typemap.jsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/wire_ty.d.tsis excluded by!**/dist/**baml_language/sdks/nodejs/bridge_nodejs/dist/wire_ty.jsis excluded by!**/dist/**baml_language/sdks/python/uv.lockis excluded by!**/*.lock
📒 Files selected for processing (115)
.github/workflows/build2-nodejs-sdk.reusable.yaml.github/workflows/cargo-tests.reusable.yaml.github/workflows/ci.yaml.github/workflows/publish2-nodejs-sdk.yamlbaml_language/.config/nextest.tomlbaml_language/crates/baml_builtins2/keyword_docs/baml_keywords.yamlbaml_language/crates/baml_cli/src/init_command.rsbaml_language/crates/baml_codegen_types/src/generator_fields.rsbaml_language/crates/baml_codegen_types/src/ty.rsbaml_language/crates/baml_release/src/manifest.rsbaml_language/crates/bex_engine/src/trace_value_encode.rsbaml_language/crates/bex_engine/tests/host_value_callable.rsbaml_language/crates/bex_engine/tests/prof_gate.rsbaml_language/crates/bridge_cffi/src/baml_to_host.rsbaml_language/crates/bridge_cffi/src/ffi/handle.rsbaml_language/crates/bridge_cffi/src/ffi/host_value.rsbaml_language/crates/bridge_cffi/src/lib.rsbaml_language/crates/bridge_ctypes/README.mdbaml_language/crates/bridge_ctypes/src/handle_table.rsbaml_language/crates/bridge_ctypes/src/lib.rsbaml_language/crates/bridge_ctypes/src/traceback.rsbaml_language/crates/bridge_ctypes/src/ty_decode.rsbaml_language/crates/bridge_ctypes/src/ty_encode.rsbaml_language/crates/bridge_ctypes/src/value_decode.rsbaml_language/crates/bridge_ctypes/src/value_encode.rsbaml_language/crates/bridge_ctypes/types/baml_bridge/cffi/v1/baml_handle.protobaml_language/crates/bridge_ctypes/types/baml_bridge/cffi/v1/baml_inbound.protobaml_language/crates/bridge_ctypes/types/baml_bridge/cffi/v1/baml_outbound.protobaml_language/crates/bridge_ctypes/types/baml_bridge/cffi/v1/baml_type.protobaml_language/crates/bridge_wasm/src/handle.rsbaml_language/crates/bridge_wasm/src/host_value.rsbaml_language/crates/bridge_wasm/src/lib.rsbaml_language/crates/bridge_wasm/tests/host_callable.rsbaml_language/crates/bridge_wasm/tests/wasm_fs_glob.rsbaml_language/sdk_tests/DEVELOPMENT.mdbaml_language/sdk_tests/README.mdbaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_cancellation.pybaml_language/sdk_tests/crates/python_pydantic2/function_calls/customizable/test_errors.pybaml_language/sdk_tests/crates/python_pydantic2/setup.ps1baml_language/sdk_tests/crates/python_pydantic2/setup.shbaml_language/sdk_tests/crates/python_pydantic2/type_shapes/customizable/roundtrip_tests/test_media.pybaml_language/sdk_tests/crates/typescript_node/function_calls/customizable/cancellation.test.tsbaml_language/sdk_tests/crates/typescript_node/function_calls/customizable/union_throws.test.tsbaml_language/sdk_tests/crates/typescript_node/setup.shbaml_language/sdk_tests/harness_setup/src/python_pydantic2.rsbaml_language/sdk_tests/harness_setup/src/templates/package.jsonbaml_language/sdk_tests/harness_setup/src/templates/pyproject.tomlbaml_language/sdk_tests/harness_setup/src/typescript_node.rsbaml_language/sdks/go/bridge_go/build.shbaml_language/sdks/go/bridge_go/pkg/host_value.gobaml_language/sdks/go/bridge_go/pkg/proto.gobaml_language/sdks/nodejs/bridge_nodejs/package.jsonbaml_language/sdks/nodejs/bridge_nodejs/src/media.rsbaml_language/sdks/nodejs/bridge_nodejs/src/runtime.rsbaml_language/sdks/nodejs/bridge_nodejs/tests/test_decode_call_result.test.tsbaml_language/sdks/nodejs/bridge_nodejs/typescript_src/define_function.tsbaml_language/sdks/nodejs/bridge_nodejs/typescript_src/generated-header.txtbaml_language/sdks/nodejs/bridge_nodejs/typescript_src/host_value_registry.tsbaml_language/sdks/nodejs/bridge_nodejs/typescript_src/proto.tsbaml_language/sdks/nodejs/bridge_nodejs/typescript_src/proto/baml_cffi.d.tsbaml_language/sdks/nodejs/bridge_nodejs/typescript_src/proto/baml_cffi.jsbaml_language/sdks/nodejs/bridge_nodejs/typescript_src/stream.tsbaml_language/sdks/nodejs/bridge_nodejs/typescript_src/typemap.tsbaml_language/sdks/nodejs/bridge_nodejs/typescript_src/wire_ty.tsbaml_language/sdks/nodejs/sdkgen_typescript_node/src/emit/class.rsbaml_language/sdks/nodejs/sdkgen_typescript_node/src/emit/typemap_file.rsbaml_language/sdks/nodejs/sdkgen_typescript_node/src/leaf.rsbaml_language/sdks/nodejs/sdkgen_typescript_node/src/lib.rsbaml_language/sdks/python/README.mdbaml_language/sdks/python/generate_stubs.pybaml_language/sdks/python/pyproject.tomlbaml_language/sdks/python/rust/bridge_python/src/baml_call_context.rsbaml_language/sdks/python/rust/bridge_python/src/baml_core/baml_py/__init__.pyibaml_language/sdks/python/rust/bridge_python/src/errors.rsbaml_language/sdks/python/rust/bridge_python/src/host_value.rsbaml_language/sdks/python/rust/bridge_python/src/media.rsbaml_language/sdks/python/rust/bridge_python/src/py_handle.rsbaml_language/sdks/python/rust/bridge_python/src/runtime.rsbaml_language/sdks/python/rust/sdkgen_python_pydantic2/src/emit/typemap_file.rsbaml_language/sdks/python/rust/sdkgen_python_pydantic2/src/leaf.rsbaml_language/sdks/python/rust/sdkgen_python_pydantic2/src/lib.rsbaml_language/sdks/python/setup.shbaml_language/sdks/python/src/baml_bridge/__init__.pybaml_language/sdks/python/src/baml_bridge/_stream.pybaml_language/sdks/python/src/baml_bridge/baml_py.pyibaml_language/sdks/python/src/baml_bridge/cffi/__init__.pybaml_language/sdks/python/src/baml_bridge/cffi/v1/__init__.pybaml_language/sdks/python/src/baml_bridge/cffi/v1/baml_handle_pb2.pybaml_language/sdks/python/src/baml_bridge/cffi/v1/baml_handle_pb2.pyibaml_language/sdks/python/src/baml_bridge/cffi/v1/baml_inbound_pb2.pybaml_language/sdks/python/src/baml_bridge/cffi/v1/baml_inbound_pb2.pyibaml_language/sdks/python/src/baml_bridge/cffi/v1/baml_outbound_pb2.pybaml_language/sdks/python/src/baml_bridge/cffi/v1/baml_outbound_pb2.pyibaml_language/sdks/python/src/baml_bridge/cffi/v1/baml_type_pb2.pybaml_language/sdks/python/src/baml_bridge/cffi/v1/baml_type_pb2.pyibaml_language/sdks/python/src/baml_bridge/ctx_manager.pybaml_language/sdks/python/src/baml_bridge/errors.pybaml_language/sdks/python/src/baml_bridge/proto.pybaml_language/sdks/python/src/baml_bridge/py.typedbaml_language/sdks/python/src/baml_bridge/typemap.pybaml_language/sdks/python/src/baml_core/cffi/v1/baml_handle_pb2.pybaml_language/sdks/python/src/baml_core/cffi/v1/baml_inbound_pb2.pybaml_language/sdks/python/src/baml_core/cffi/v1/baml_outbound_pb2.pybaml_language/sdks/python/src/baml_core/cffi/v1/baml_type_pb2.pybaml_language/sdks/python/tests/conftest.pybaml_language/sdks/python/tests/test_bigint.pybaml_language/sdks/python/tests/test_decode_handle.pybaml_language/sdks/python/tests/test_engine.pybaml_language/sdks/python/tests/test_host_callable.pybaml_language/sdks/python/tests/test_media.pybaml_language/sdks/python/tests/test_proto_decode_typemap.pybaml_language/sdks/python/tests/test_proto_generics.pybaml_language/sdks/python/tests/test_typemap.pyscripts/baml-language-versionscripts/baml-release-manifests
💤 Files with no reviewable changes (4)
- baml_language/sdks/python/src/baml_core/cffi/v1/baml_inbound_pb2.py
- baml_language/sdks/python/src/baml_core/cffi/v1/baml_outbound_pb2.py
- baml_language/sdks/python/src/baml_core/cffi/v1/baml_handle_pb2.py
- baml_language/sdks/python/src/baml_core/cffi/v1/baml_type_pb2.py
Rename the published SDK bridge package coherently: - PyPI: baml-core -> baml-bridge (import module baml_core -> baml_bridge) - npm: @boundaryml/baml-core-node -> @boundaryml/baml-bridge (incl. platform packages) - proto package baml_core.cffi.v1 -> baml_bridge.cffi.v1 (regenerated Python pb2 + Go stubs + Rust prost) - release/version plumbing (scripts/baml-language-version, baml-release-manifests, workflows) Internal (unpublished) Rust module bridge_ctypes::baml_core is intentionally kept.
sxlijin
force-pushed
the
sam/rename-baml-bridge
branch
from
July 7, 2026 21:35
79ec83e to
111589d
Compare
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the published SDK bridge package coherently:
Internal (unpublished) Rust module bridge_ctypes::baml_core is intentionally kept.
Summary by CodeRabbit
New Features
@boundaryml/baml-bridge).Bug Fixes
baml_bridge_pypi, Node bridge dist tags/packages).