Repository navigation
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9fdf604e95
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| anyhow = { workspace = true } | ||
| flate2 = { workspace = true } | ||
| reqwest = { workspace = true, features = [ "blocking", "rustls" ] } | ||
| reqwest = { workspace = true, features = [ "blocking", "rustls-no-provider" ] } |
There was a problem hiding this comment.
Install a rustls provider before using reqwest
When this crate is built outside the whole-workspace CI feature set (for example the release/downloader path used by baml_release, and the same pattern was added in crates/baml), reqwest now uses rustls-no-provider but neither crate installs a rustls::crypto provider before Client::builder().build() in the HTTPS download code. Reqwest documents that rustls-no-provider requires a provider to be installed before building a client and otherwise panics at construction time, so self-update/release downloads can fail even though the old rustls feature supplied the provider automatically.
Useful? React with 👍 / 👎.
Binary size checks passed✅ 5 passed
Generated by |
9401ebe to
eab40b0
Compare
9fdf604 to
4740c1b
Compare
…ing, native per-platform, windows sdk uv dedupe
… Cargo.toml crypto-provider edits
eab40b0 to
3b1029c
Compare
4740c1b to
08b7d49
Compare
Stacked on #3688 (
sam/ci-restructure). Splits the ring-crypto change out of the CI restructure into its own reviewable PR.Switches the whole-workspace native test builds (linux/macos/windows
cargo test) from--all-featuresto a curatedRING_FEATURESset that uses theringcrypto provider instead ofaws-lc, droppingaws-lc-sysand its cmake/C/NASM cold-build cost (build-caching/04 Exp 10).RING_FEATURESworkflow env + points the 3 native cargo-test jobs at it.baml/baml_releasereqwestrustls→rustls-no-provider;baml_tests/bex_enginesys_nativeaws-crypto→ring-crypto.default = ["aws-crypto"], so release artifacts are unchanged — this only affects test builds.-p-scoped jobs (snapshot, sdk-tests) keep--all-features(cargo's--features <pkg>/<feat>requires the pkg in the-pselected set).🤖 Generated with Claude Code