Skip to content

ci: ring-crypto for test builds (drop aws-lc-sys) - #3703

Closed
sxlijin wants to merge 2 commits into
canaryfrom
sam/ci-restructure-ring
Closed

sxlijin wants to merge 2 commits into
canaryfrom
sam/ci-restructure-ring

Conversation

@sxlijin

@sxlijin sxlijin commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

Stacked on #3688 (sam/ci-restructure). Splits the ring-crypto change out of the CI restructure into its own reviewable PR.

Switches the whole-workspace native test builds (linux/macos/windows cargo test) from --all-features to a curated RING_FEATURES set that uses the ring crypto provider instead of aws-lc, dropping aws-lc-sys and its cmake/C/NASM cold-build cost (build-caching/04 Exp 10).

  • Adds the RING_FEATURES workflow env + points the 3 native cargo-test jobs at it.
  • 4 source edits: baml/baml_release reqwest rustls → rustls-no-provider; baml_tests/bex_engine sys_native aws-crypto → ring-crypto.
  • Shipping crates keep default = ["aws-crypto"], so release artifacts are unchanged — this only affects test builds.
  • -p-scoped jobs (snapshot, sdk-tests) keep --all-features (cargo's --features <pkg>/<feat> requires the pkg in the -p selected set).

🤖 Generated with Claude Code

@vercel

vercel Bot commented Jun 5, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
beps Ready Ready Preview, Comment Jun 6, 2026 1:05am
promptfiddle Ready Ready Preview, Comment Jun 6, 2026 1:05am
promptfiddle2 Error Error Jun 6, 2026 1:05am

Request Review

@coderabbitai

coderabbitai Bot commented Jun 5, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 53c37439-2cd0-4c1f-80bf-62770606a05a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sam/ci-restructure-ring

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@vercel
vercel Bot temporarily deployed to Preview – beps June 5, 2026 00:34 Inactive
@github-actions

github-actions Bot commented Jun 5, 2026 •

Copy link
Copy Markdown

⏭️ Performance benchmarks were skipped

Perf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to canary/main.

To run them on this PR, do any of the following, then push a commit (or re-run CI):

  • Add RUN_CODSPEED=1 to the PR description, or
  • Include run-perf or /perf in the PR title or any commit message.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9fdf604e95

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

anyhow = { workspace = true }
flate2 = { workspace = true }
reqwest = { workspace = true, features = [ "blocking", "rustls" ] }
reqwest = { workspace = true, features = [ "blocking", "rustls-no-provider" ] }

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Install a rustls provider before using reqwest

When this crate is built outside the whole-workspace CI feature set (for example the release/downloader path used by baml_release, and the same pattern was added in crates/baml), reqwest now uses rustls-no-provider but neither crate installs a rustls::crypto provider before Client::builder().build() in the HTTPS download code. Reqwest documents that rustls-no-provider requires a provider to be installed before building a client and otherwise panics at construction time, so self-update/release downloads can fail even though the old rustls feature supplied the provider automatically.

Useful? React with 👍 / 👎.

@vercel
vercel Bot temporarily deployed to Preview – promptfiddle2 June 5, 2026 00:39 Inactive
@github-actions

github-actions Bot commented Jun 5, 2026 •

Copy link
Copy Markdown

⚠️ Missing size-gate report(s):

  • windows (job result: success)

The unified report below only reflects platforms that produced output.

Binary size checks passed

✅ 5 passed

Artifact Platform File Gzip Gated on Baseline Delta Status
✅ baml-cli Linux 🔒 17.8 MB 7.6 MB file 24.1 MB -6.3 MB (-26.0%) OK
✅ packed-program Linux 🔒 12.9 MB 5.5 MB file 15.1 MB -2.2 MB (-14.4%) OK
✅ baml-cli macOS 🔒 13.6 MB 6.6 MB file 18.2 MB -4.6 MB (-25.3%) OK
✅ packed-program macOS 🔒 9.9 MB 4.8 MB file 11.5 MB -1.6 MB (-14.3%) OK
✅ bridge_wasm WASM 11.9 MB 🔒 3.4 MB gzip 3.9 MB -501.0 KB (-12.9%) OK

🔒 = the size this artifact is GATED on (ceiling + delta). Binaries gate on file size (installed binary); WASM gates on gzip (download size). The other size is shown for information only.


Generated by cargo size-gate · workflow run

@sxlijin
sxlijin force-pushed the sam/ci-restructure branch from 9401ebe to eab40b0 Compare June 5, 2026 00:48
@sxlijin
sxlijin force-pushed the sam/ci-restructure-ring branch from 9fdf604 to 4740c1b Compare June 5, 2026 00:48
@vercel
vercel Bot temporarily deployed to Preview – beps June 5, 2026 00:49 Inactive
@vercel
vercel Bot temporarily deployed to Preview – promptfiddle June 5, 2026 01:07 Inactive
@sxlijin
sxlijin force-pushed the sam/ci-restructure branch from eab40b0 to 3b1029c Compare June 5, 2026 01:29
@sxlijin
sxlijin force-pushed the sam/ci-restructure-ring branch from 4740c1b to 08b7d49 Compare June 5, 2026 01:30
@vercel
vercel Bot temporarily deployed to Preview – beps June 5, 2026 01:30 Inactive
@vercel
vercel Bot temporarily deployed to Preview – promptfiddle2 June 5, 2026 01:36 Inactive
@vercel
vercel Bot temporarily deployed to Preview – promptfiddle June 5, 2026 01:48 Inactive
Base automatically changed from sam/ci-restructure to canary June 5, 2026 04:58
@sxlijin sxlijin closed this Jun 7, 2026
@sxlijin
sxlijin deleted the sam/ci-restructure-ring branch June 7, 2026 17:26

This branch was previously deployed

3 inactive deployments
Preview – promptfiddle — 08b7d49b Deployed Jun 5, 2026 by vercel[bot]
Preview – promptfiddle2 — 08b7d49b Deployed Jun 5, 2026 by vercel[bot]
Preview – beps — 08b7d49b Deployed Jun 5, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant