Repository navigation
chore: speed up sdk tests, set up actionlint - #3660
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThis PR adds an actionlint config and registers actionlint in ChangesCI workflow tooling and test scoping
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
a8dcc49 to
af7ace4
Compare
⏭️ Performance benchmarks were skippedPerf benchmarks (CodSpeed) are opt-in on pull requests — they no longer run on every push. They always run automatically after merge to To run them on this PR, do any of the following, then push a commit (or re-run CI):
|
af7ace4 to
c0fd379
Compare
Binary size checks passed✅ 7 passed
Generated by |
c0fd379 to
959ad64
Compare
596c81b to
6e25687
Compare
959ad64 to
f8e2166
Compare
The "Run sdk test setup" / "Run sdk tests" steps ran `cargo nextest run`
without `-p`, so nextest compiled the whole workspace's ~145 test binaries
to run a single package's tests (~2m30s/step even on a fully hot cache).
The `-E` filter only selects which tests run, not what compiles. The SDK
crates have no cargo dependency on the bridge cdylibs, so adding
`-p ${{ matrix.package-name }}` is safe.
Tooling: add actionlint to mise.toml plus a .github/actionlint.yaml that
declares our Blacksmith self-hosted runner labels, so the workflows lint
clean locally and in CI.
Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
f8e2166 to
d791593
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
mise.toml (1)
40-40: ⚡ Quick winAllow
actionlint = "latest"inmise.toml— mise supports it.
actionlintis included in mise’s official registry, sosetup-miseshould be able to install it frommise.toml. Optional: add a brief category/comment header around it to keep grouping consistent.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@mise.toml` at line 40, Update the setup-mise installation logic to accept and install entries specified as actionlint = "latest" in mise.toml: when parsing entries like the string "latest" for an action (e.g., actionlint), resolve it to the registry's latest version instead of failing or requiring a pinned version, then proceed with normal install; also add an optional grouped comment/header near the actionlint entry in mise.toml to keep consistency with other tool groups. Ensure the code paths that lookup registry entries and call install use the same identifier (actionlint) and handle the "latest" sentinel by querying the registry for its current version before downloading.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@mise.toml`:
- Line 40: Update the setup-mise installation logic to accept and install
entries specified as actionlint = "latest" in mise.toml: when parsing entries
like the string "latest" for an action (e.g., actionlint), resolve it to the
registry's latest version instead of failing or requiring a pinned version, then
proceed with normal install; also add an optional grouped comment/header near
the actionlint entry in mise.toml to keep consistency with other tool groups.
Ensure the code paths that lookup registry entries and call install use the same
identifier (actionlint) and handle the "latest" sentinel by querying the
registry for its current version before downloading.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: e319e472-818d-4f2b-8bf3-dc69ca452f45
📒 Files selected for processing (3)
.github/actionlint.yaml.github/workflows/cargo-tests.reusable.yamlmise.toml
✅ Files skipped from review due to trivial changes (1)
- .github/actionlint.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/cargo-tests.reusable.yaml
Summary by CodeRabbit