feat(video): add mixed references with matching budget reservations - #155
Open
KillerQueen-Z wants to merge 2 commits into
Open
KillerQueen-Z wants to merge 2 commits into
KillerQueen-Z wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add client parameters for mixed reference media, supported output controls, 2.5 first/last frames and 30 images, and last-frame results. These fields are forwarded through the existing Base, Solana and account transports; acceptance depends on the gateway capability and rollout status below. Include the gateway’s existing reference-media surcharge in budget reservations before signing, and apply URL/SSRF checks to the new media inputs.
Model-specific combinations and unsupported controls are rejected before payment. Existing authoritative-quote checks, paid-request accounting and polling deadlines remain intact.
Validation
Full
npm test: 1,321 passed. Focused schema/video regression suite: 48 passed. Re-measured the expanded tool schema and regenerated both context-cost cards; synchronized the README and overhead documentation (full: 13,456 tokens; media: 6,240). This resolves all three failing CI assertions. Earlier TypeScript checking and MCP Apps/server/declaration build passed. SSRF, quote rejection, deadline accounting and settlement tests use mocked transport.Rollout and limits
This PR does not deploy or change
R2V_ENABLED. Base #719 is merged. Solana #367 was closed after the product decision to offer reference media through api.blockrun.ai; Solana #374 (still open at this review) implements that refusal. Do not assume Solana capability parity or enable its reference-media switch. Account API #282 remains open. Publish only after the intended gateway capabilities are deployed; accepting a client parameter does not imply that every gateway supports it.No new paid upstream renders were performed. New request/response behavior is validated against the captured public upstream parameter schema and mocked contract/payment tests; perform a small paid render smoke test before production enablement. Automatic duration, editing/extension, 2.5 reference video/audio and 1080p, callbacks and draft/flex remain held pending cost/output or lifecycle validation.
See
SEEDANCE_CAPABILITIES.mdfor input examples and capability limits. No authentication, signed-quote format or settlement formula changes.Related PRs