fix(report): recognise any test_ module, not just three families - #35
Merged
Conversation
…_/test_verify_ parse_junit() extracted the module from a JUnit classname only when a dotted part started with test_msg_, test_sign_ or test_verify_. Anything else produced no 'mod::meth' key at all, and _lookup() has no bare-method fallback (deliberately -- a method-name collision once rendered a never-run test as PASS). So a catalogued test in a module outside those three families is INVISIBLE to the report: its results are parsed, then silently dropped, and the section renders "Pending (no firmware support yet)". That is exactly what happened to the new Storage Upgrade Preservation section: all eight tests in test_storage_version_gate.py were passing while the report showed the feature as unsupported. A section that says "pending" when the tests are green is worse than no section, because it reads as a deliberate gap. Widened to any part starting with test_. Native gtest suites are unaffected -- they carry a bare classname with no dot and were already keyed as Suite::Test. Report on the same inputs: 18 pending -> 0 pending.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parse_junit()extracted the module from a JUnit classname only when a dotted part started withtest_msg_,test_sign_ortest_verify_. Anything else produced nomod::methkey at all, and_lookup()has no bare-method fallback (deliberately — a method-name collision once rendered a never-run test as PASS).So a catalogued test in a module outside those three families is invisible to the report: results parsed, then silently dropped, and the section renders "Pending (no firmware support yet)".
That is exactly what happened to the new Storage Upgrade Preservation section: all eight tests in
test_storage_version_gate.pywere passing while the report showed the feature as unsupported. A section that says "pending" when the tests are green is worse than no section — it reads as a deliberate gap.Widened to any part starting with
test_. Native gtest suites unaffected (bare classname, no dot, already keyedSuite::Test).Report on identical inputs: 18 pending → 0 pending.