Repository navigation
Give BigVolumeBrowser API outside BdvUtils and PyramidalService - #192
Open
stefanhahmann wants to merge 4 commits into
Open
stefanhahmann wants to merge 4 commits into
stefanhahmann wants to merge 4 commits into
Conversation
The BDV-specific API gets its own package, which OmeroDisplay will join. ome.zarr.fiji.PyramidalBdv stays as a deprecated subclass until 0.11, so BigVolumeBrowser and mobie-io keep compiling (#188). Co-Authored-By: Claude Opus 5.5 <[email protected]>
BigVolumeBrowser needed PyramidalService only to pass it to BdvUtils.registerViewer, which is now deprecated. The new method looks the service up in the pyramidal's context, so BdvUtils.show and showInOneWindow drop their PyramidalService parameter (#188). Co-Authored-By: Claude Opus 5.5 <[email protected]>
BigVolumeBrowser applies the same OMERO channel colors, ranges and start timepoint as BigDataViewer. The three BdvUtils methods it used for that are deprecated in favor of OmeroDisplay.channels, apply and setTimepoint (#188). Co-Authored-By: Claude Opus 5.5 <[email protected]>
It used the old ome.zarr.fiji.PyramidalBdv and the BdvUtils methods that OmeroDisplay and PyramidalBdv.registerViewer replace. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #188.
BigVolumeBrowser no longer needs
ome.zarr.fiji.utilorome.zarr.fiji.plugins, so both become project internal, which is better from an API point of view. API packages afterwards:ome.zarr.fiji,.bdv,.read,.open.API changes by artefact
ome-zarr-fijiNew package
ome.zarr.fiji.bdv:PyramidalBdvmoves here.ome.zarr.fiji.PyramidalBdvstays as a deprecated subclass until 0.11.PyramidalBdv.registerViewer( AbstractViewerPanel )looks upPyramidalServicein its own context.OmeroDisplaywithchannels,applyandsetTimepoint.Deprecated, to be removed in 0.11:
BdvUtils.registerViewer,omeroChannels,setChannelPropertiesandsetTimepoint. They delegate to the new methods.Breaking:
BdvUtils.showandshowInOneWindowdrop theirPyramidalServiceparameter.show( PyramidalBdv, PyramidalService )is removed.ome-zarr-fiji-ui,ome-zarr-imglib2,ome-zarr-n5,ome-zarr-zarrjavaNo API changes.
Downstream
PyramidalBdvimport toome.zarr.fiji.bdvinPyramidalN5ImageDataandPyramidalZarrJavaImageDataonce this is released. mobie-viewer-fiji needs no change.Testing
Full suite passes locally.
🤖 Generated with Claude Code