Repository navigation
feat(ui): add SearchCombobox primitive - #35
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
There was a problem hiding this comment.
Copilot was unable to review this pull request due to rate limiting. Please try again later. See Usage limits for GitHub Copilot for details.
Merged
1 of 2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
SearchCombobox, the pill-shaped search field currently hand-styled inside app-kit-ui'sGenreSearch, as a genericuiprimitive overCombobox. First step of the unified search work (app-kit-uiSearchBoxand the Grow map search build on it).Changes
SearchCombobox: search icon / delayed spinner, optional clear button (onClear),leadingslot (e.g. a Previous button) with matching input padding, touch-target sizing from tokens.SEARCH_LEADING_BUTTON_CLASSfor the leading action.Test plan
SearchCombobox.test.tsx: picks, clear button presence, leading slot and loading labelpnpm lint,pnpm test(52 pass),pnpm buildStandard-depth review: no findings.
🤖 Generated with Claude Code