Repository navigation
Conversation
- CI: run mypy, test with the lowest allowed versions, check coverage (90% minimum) with a PR comment and badge, and check the build - Release: publish to PyPI with trusted publishing when a GitHub release is published - Fix the mypy errors in the SDK code - Add coverage and mypy badges; ignore .coverage and dist/ Co-Authored-By: Claude Opus 5 <[email protected]>
…tations - Turn on branch coverage (92% total) - Check the 90% minimum after posting the coverage comment, so the comment shows even when coverage drops - Publish with pypa/gh-action-pypi-publish, which adds PEP 740 attestations Co-Authored-By: Claude Opus 5 <[email protected]>
Coverage reportClick to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||||||||||||||
Tags and branches can be moved to new code; a commit SHA cannot. Dependabot updates the SHA and the version comment. Co-Authored-By: Claude Opus 5 <[email protected]>
AndreasPatakis
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Adds more repo health checks.
CI (
ci.yml)mypy src. It uses the pydantic plugin and skips the generated gRPC code.pyproject.tomlallows, so those minimums stay true.main, it saves the coverage badge to thepython-coverage-comment-action-databranch, which the action creates on its first run.twine check --strict.Release (
release.yml)Publishing a GitHub release builds the package and uploads it to PyPI. It uses trusted publishing, so no API token is stored, and it adds PEP 740 attestations.
Code: fixes the mypy errors. Behavior doesn't change.
query_paramsheld two different types..model_dump()is now chained onto it, in 3 places.# type: ignore[prop-decorator]on the@computed_fieldproperties, as pydantic's docs recommend.Other
devextra: addedmypy==2.3.1,pytest-cov,types-grpcioandtypes-protobuf.uv.lockis updated..gitignore: added.coverageanddist/.Actions pinned by commit SHA in both workflows, with the version kept as a comment. A tag can be moved to new code; a SHA can't. This matters most for the release job, which can publish to PyPI. Dependabot updates the SHA and the comment.
Related issue or ticket
ALTO-5546
How it was tested
uv lock --check, ruff,mypy srcandpytest --covpass (68 tests).pip install -e ".[dev]", mypy and pytest pass.coverage reportfails when coverage is below the minimum.Setup needed
On PyPI, open the project's Publishing settings and add a GitHub trusted publisher:
BehavioralSignalTechnologiesbehavioralsignals-pythonrelease.ymlpypiThis is needed before the 1.0.0 release.
Check that no branch rule protects
python-coverage-comment-action-data.The coverage badge shows as broken until the first CI run on
mainafter merge.PRs from forks get no coverage comment, because their token is read-only. The 90% check still runs for them.
Checklist
ruff check,ruff format,mypy srcandpytestREADME.mdandexamples/, if usage changed (usage didn't change; only badges were added)