Skip to content

Match the controlled Windows setup-error fixture diagnostic (#907) #918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
i2cjak merged 1 commit into from
Nov 4, 2026
Merged

Match the controlled Windows setup-error fixture diagnostic (#907) #918

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions desktop/test/windows-standard-user.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,22 +92,26 @@ async function main(){
// Exercise the error UI before teardown. A resident service's handles or
// a hung adapter close must not strand the second, independent home.
phase('failure-launch');
// This override is outside the bundled service directory: BUILD.json and
// cygpath.exe are absent, so launchPaths fails before a native spawn.
// Assert that real setup diagnostic, rather than inventing ENOENT.
const expectedFailure='Cannot map paths with the packaged Windows runtime';
const failedEnv={...env,BACKPLANE_HOME:path.join(out,'Failure home'),BACKPLANE_SERVICE:path.join(out,'missing-service.exe')};
app=await _electron.launch({executablePath:executable,args:[],env:failedEnv,chromiumSandbox:true,timeout:60000});
owned.push({app,child:app.process(),label:'failure UI'});
page=await app.firstWindow();await page.locator('#retry').waitFor({state:'visible',timeout:15000});
const message=await page.locator('#status').innerText();assert.match(message,/ENOENT/);
const message=await page.locator('#status').innerText();assert(message.includes(expectedFailure),message);
assert.equal((await page.evaluate(()=>backplaneDesktop.connectionState())).phase,'error');
phase('failure-visible');
await page.waitForTimeout(7000);assert.equal(await page.locator('#status').innerText(),message);assert(await page.locator('#retry').isVisible());
assert.equal((await page.evaluate(()=>backplaneDesktop.connectionState())).phase,'error');
await page.screenshot({path:path.join(out,'startup-error.png')});
report.failureUi={phase:'error',nativeError:'ENOENT',stableForMs:7000,retryVisible:true};
report.checks.push('packaged missing-service error stays visible with Retry after seven seconds');save();
report.failureUi={phase:'error',startupError:expectedFailure,stableForMs:7000,retryVisible:true};
report.checks.push('packaged service setup error stays visible with Retry after seven seconds');save();
await page.locator('#retry').click();
await page.locator('#retry').waitFor({state:'visible',timeout:15000});
await page.waitForFunction(()=>backplaneDesktop.connectionState()?.phase==='error',null,{timeout:15000});
assert.match(await page.locator('#status').innerText(),/ENOENT/);assert(await page.locator('#retry').isVisible());
assert((await page.locator('#status').innerText()).includes(expectedFailure));assert(await page.locator('#retry').isVisible());
report.failureUi.explicitRetryReturnsVisibleError=true;save();
}finally{
phase('test-owned-ui-cleanup');
Expand Down
Loading