Repository navigation
fix(example): await mock registrations and nest suites under one describe - #43
Merged
Merged
Conversation
…ribe twd-lint found 68 twd.mockRequest calls without await and 9 top-level describe blocks in the example app's test file. The awaits were added with twd-lint --fix; the suites now sit under one root describe, with every existing title unchanged.
TWD Contract Validation
23 passed · 41 failed · 3 warnings · 1 skipped Failed validations./contracts/users-3.0.json
./contracts/posts-3.1.json
./contracts/products-3.0.json
./contracts/events-3.1.json
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes the mistakes twd-lint found in the example app's TWD tests (
test-example-app/src/App.twd.test.ts):twd.mockRequest(...)calls withoutawait(twd/no-missing-await).mockRequestreturns a promise; withoutawaitthe test can move on before the mock is registered. Added withnpx twd-lint --fix.describeblocks (twd/single-top-level-describe). They now sit under one root,describe("Test example app", ...). Every existingdescribeandittitle is unchanged; full test names gain theTest example app >prefix.Only the example app changes; nothing in the CLI or the published package.
Type of Change
Testing
Test Details
Ran the example suite locally with this branch's CLI (
node ../bin/twd-cli.js runagainst the example's dev server), before and after the change:mainThe contract errors are the deliberate invalid mocks of the "Mismatches" suites (mode
warn). Sharding is unaffected:selectShardIdssplits by test, not bydescribe.npx twd-lint test-example-app/srcnow reports no problems.🤖 Generated with Claude Code