Align SSH public key location with default home folder configuration - #2006
Open
Xin Wang (wangxin) wants to merge 1 commit into
Open
Align SSH public key location with default home folder configuration#2006Xin Wang (wangxin) wants to merge 1 commit into
Xin Wang (wangxin) wants to merge 1 commit into
Conversation
The default home folder of new user can be configured in `/etc/default/useradd`.
However, the VMAccess extension always assumes that the SSH public key is under
`/home/<user_name>/.ssh/authorized_keys`. Location of the SSH public key must
be aligned with the user's home folder. Otherwise, SSH authentciation would fail.
For example, if "HOME=/data/home" is configured in /etc/defaults/useradd, then home
folder of new user would be "/data/home/<user_name>".
The problem is that SSH public key provided by user would be put in
"/home/<user_name>/.ssh/authorized_keys". Then the new user cannot authentication
by SSH key.
The code for specifying SSH public key location:
```
pub_path = os.path.join('/home/', user_name, '.ssh',
'authorized_keys')
```
This change updated the hardcoded "/home" to "$HOME".
The subsequent code for preparing dir will replace "$HOME" string with the actual default home folder location:
```
pub_path = ovf_env.prepare_dir(pub_path, MyDistro)
```
Signed-off-by: Xin Wang <[email protected]>
Xin Wang (wangxin)
requested review from
a team,
Bhaskar Brahma (D1v38om83r) and
nkuchta
as code owners
January 6, 2025 07:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default home folder of new user can be configured in
/etc/default/useradd.However, the VMAccess extension always assumes that the SSH public key is under
/home/<user_name>/.ssh/authorized_keys. Location of the SSH public key must be aligned with the user's home folder. Otherwise, SSH authentcation would fail.For example, if "HOME=/data/home" is configured in /etc/defaults/useradd, then home folder of new user would be "/data/home/<user_name>".
The problem is that SSH public key provided by user would be put in "/home/<user_name>/.ssh/authorized_keys". Then the new user cannot authentication by SSH key.
The code for specifying SSH public key location:
This change updated the hardcoded "/home" to "$HOME". The subsequent code for preparing dir will replace "$HOME" string with the actual default home folder location: