fix(vscode): Make design-time start non-blocking on activate - #9591
Merged
Andrew Eldridge (andrew-eldridge) merged 2 commits intoSep 1, 2026
Merged
Conversation
…pt for auto-start design time non-blocking
Andrew Eldridge (andrew-eldridge)
requested review from
Bryan Bennett (bjbennet) and
Brian Lam (lambrianmsft)
and
a balanced review from Copilot
September 1, 2026 18:26
Copilot started reviewing on behalf of
Andrew Eldridge (andrew-eldridge)
September 1, 2026 18:27
View session
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
✅ Commit Type
✅ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
✅ Contributors
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | No change needed |
| Commit Type | ✅ | No change needed |
| Risk Level | ✅ | Medium is correct |
| What & Why | ✅ | No change needed |
| Impact of Change | ✅ | No change needed |
| Test Plan | ✅ | Unit tests present |
| Contributors | ✅ | Credited |
| Screenshots/Videos | Not required (non-visual) |
All required checks pass. This PR is compliant with the team template and is cleared to merge.
Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Tue, 01 Sep 2026 18:57:54 GMT
Contributor
🤖 AI PR Validation ReportPR Review ResultsThank you for your submission! Here's detailed feedback on your PR title and body compliance:✅ PR Title
❌ Commit Type
❌ Risk Level
✅ What & Why
✅ Impact of Change
✅ Test Plan
✅ Contributors
|
| Section | Status | Recommendation |
|---|---|---|
| Title | ✅ | No change needed |
| Commit Type | ❌ | Select fix |
| Risk Level | ❌ | Add risk:medium label to match body |
| What & Why | ✅ | No change needed |
| Impact of Change | ✅ | No change needed |
| Test Plan | ✅ | Check the Unit tests box |
| Contributors | ✅ | No change needed |
| Screenshots/Videos | Not applicable |
Two blocking issues: (1) no commit type selected — check fix; (2) missing risk:medium label. Your declared Medium risk in the body is correct and matches the advised estimate; just add the matching label. Fix these two items and the PR will pass.
Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Tue, 01 Sep 2026 18:27:47 GMT
Contributor
📊 Coverage CheckNo source files changed in this PR. |
Contributor
There was a problem hiding this comment.
Pull request overview
Makes VS Code extension activation non-blocking while awaiting the design-time auto-start prompt.
Changes:
- Moves design-time startup into a background telemetry operation.
- Adds activation and multi-project startup unit tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
apps/vs-code-designer/src/main.ts |
Detaches prompt and design-time startup from activation. |
apps/vs-code-designer/src/__test__/main.test.ts |
Tests non-blocking activation and startup behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Brian Lam (lambrianmsft)
approved these changes
Sep 1, 2026
Andrew Eldridge (andrew-eldridge)
merged commit Sep 1, 2026
3790ede
into
main
51 of 57 checks passed
Andrew Eldridge (andrew-eldridge)
deleted the
aeldridge/vscode-start-design-time-fix
branch
September 1, 2026 21:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Type
Risk Level
What & Why
Impact of Change
Test Plan
Contributors
Andrew Eldridge (@andrew-eldridge)