Skip to content

fix(vscode): Make design-time start non-blocking on activate - #9591

Merged
Andrew Eldridge (andrew-eldridge) merged 2 commits into
mainfrom
aeldridge/vscode-start-design-time-fix
Sep 1, 2026
Merged

fix(vscode): Make design-time start non-blocking on activate#9591
Andrew Eldridge (andrew-eldridge) merged 2 commits into
mainfrom
aeldridge/vscode-start-design-time-fix

Conversation

@andrew-eldridge

@andrew-eldridge Andrew Eldridge (andrew-eldridge) commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

  • Make 'auto start design-time' prompt non-blocking on activate

Impact of Change

  • Users: Prevents extension activation getting blocked on prompt
  • Developers: N/A
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

Andrew Eldridge (@andrew-eldridge)

@andrew-eldridge Andrew Eldridge (andrew-eldridge) added VSCode Issues or PRs specific to VS Code extension risk:medium Medium risk change with potential impact labels Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Make design-time start non-blocking on activate
  • Issue: None — valid fix: prefix with a vscode scope and a clear, descriptive summary.
  • Recommendation: No change needed.

Commit Type

  • Exactly one box selected: fix - Bug fix.
  • Matches the title prefix and the nature of the change (making design-time startup non-blocking).

Risk Level

  • Exactly one box selected (Medium) and the risk:medium label matches the body selection. This aligns with my advised estimate: the change modifies extension-distribution code (apps/vs-code-designer) activation flow, which is Medium risk.

What & Why

  • Current: "Make 'auto start design-time' prompt non-blocking on activate"
  • Issue: None — concise but clear about what and why.
  • Recommendation: No change needed.

Impact of Change

  • All three audiences addressed (Users described; Developers/System marked N/A, which is acceptable).
  • Recommendation:
    • Users: Prevents extension activation from being blocked on the auto-start prompt.
    • Developers: N/A (as stated).
    • System: N/A (as stated).

Test Plan

  • Unit tests added/updated (confirmed in diff — new activate design-time startup suite in main.test.ts covering non-blocking, multi-project, and failure cases) plus manual testing. Passes CHECK TESTS.

Contributors

  • @andrew-eldridge credited.

⚠️ Screenshots/Videos

  • No screenshots provided. The diff only touches apps/vs-code-designer/src activation logic and tests — no user-facing visual UI change — so screenshots are not required. Optional nudge only.

Summary Table

Section Status Recommendation
Title No change needed
Commit Type No change needed
Risk Level Medium is correct
What & Why No change needed
Impact of Change No change needed
Test Plan Unit tests present
Contributors Credited
Screenshots/Videos ⚠️ Not required (non-visual)

All required checks pass. This PR is compliant with the team template and is cleared to merge.


Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Tue, 01 Sep 2026 18:57:54 GMT

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Parallelize start design-time in activate, make non-blocking
  • Issue: None — valid fix: prefix with scope and a descriptive summary.
  • Recommendation: No change needed.

Commit Type

  • No commit type box is selected. You must select exactly one.
  • Based on the changes (bug fix to extension activation behavior), check - [x] fix - Bug fix.

Risk Level

  • The body selects Medium, which correctly matches the advised estimate (changes to apps/vs-code-designer extension distribution/runtime behavior → Medium). However, there is no risk:* label on the PR. Add the risk:medium label so the label matches the body selection.

What & Why

  • Current: Parallelizes design-time startup for multi-project workspaces and makes the auto-start prompt non-blocking on activate.
  • Issue: None — clear and specific.
  • Recommendation: No change needed.

Impact of Change

  • Users impact is described; Developers/System marked N/A, which is acceptable.
  • Recommendation:
    • Users: Keep as-is (faster startup, non-blocking activation).
    • Developers: N/A is fine.
    • System: N/A is fine.

Test Plan

  • Unit tests are added/updated in apps/vs-code-designer/src/__test__/main.test.ts (new activate design-time startup suite), so the test requirement is satisfied. Note: none of the checkboxes are ticked — please check - [x] Unit tests added/updated for clarity.

Contributors


⚠️ Screenshots/Videos

  • Not required — changes are to VS Code extension activation logic and tests, not visual UI components.

Summary Table

Section Status Recommendation
Title No change needed
Commit Type Select fix
Risk Level Add risk:medium label to match body
What & Why No change needed
Impact of Change No change needed
Test Plan Check the Unit tests box
Contributors No change needed
Screenshots/Videos ⚠️ Not applicable

Two blocking issues: (1) no commit type selected — check fix; (2) missing risk:medium label. Your declared Medium risk in the body is correct and matches the advised estimate; just add the matching label. Fix these two items and the PR will pass.


Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Tue, 01 Sep 2026 18:27:47 GMT

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Check

No source files changed in this PR.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Makes VS Code extension activation non-blocking while awaiting the design-time auto-start prompt.

Changes:

  • Moves design-time startup into a background telemetry operation.
  • Adds activation and multi-project startup unit tests.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
apps/vs-code-designer/src/main.ts Detaches prompt and design-time startup from activation.
apps/vs-code-designer/src/__test__/main.test.ts Tests non-blocking activation and startup behavior.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread apps/vs-code-designer/src/main.ts
@andrew-eldridge Andrew Eldridge (andrew-eldridge) changed the title fix(vscode): Parallelize start design-time in activate, make non-blocking fix(vscode): Make design-time start non-blocking on activate Sep 1, 2026
@andrew-eldridge
Andrew Eldridge (andrew-eldridge) merged commit 3790ede into main Sep 1, 2026
51 of 57 checks passed
@andrew-eldridge
Andrew Eldridge (andrew-eldridge) deleted the aeldridge/vscode-start-design-time-fix branch September 1, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:medium Medium risk change with potential impact VSCode Issues or PRs specific to VS Code extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants