Skip to content

fix(vscode): Remove defaultLogicAppPath context - #9588

Merged
Andrew Eldridge (andrew-eldridge) merged 3 commits into
mainfrom
aeldridge/vscode-remove-default-la
Sep 1, 2026
Merged

fix(vscode): Remove defaultLogicAppPath context#9588
Andrew Eldridge (andrew-eldridge) merged 3 commits into
mainfrom
aeldridge/vscode-remove-default-la

Conversation

@andrew-eldridge

@andrew-eldridge Andrew Eldridge (andrew-eldridge) commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Remove ext.defaultLogicAppPath and instead explicitly resolve logic app (projectPath) in data map commands either through automatic selection, command context, or prompt. Workspaces can have multiple projects so always using ext.defaultLogicAppPath makes commands unusable on all projects except the default.

Impact of Change

  • Users: Fixes some data map commands in workspaces with multiple projects
  • Developers: N/A
  • System: N/A

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in:

Contributors

Andrew Eldridge (@andrew-eldridge)

@andrew-eldridge Andrew Eldridge (andrew-eldridge) added VSCode Issues or PRs specific to VS Code extension risk:low Low risk change with minimal impact labels Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vscode): Remove defaultLogicAppPath context
  • Issue: None — uses a valid fix: prefix with a vscode scope and is descriptive.
  • Recommendation: No changes needed.

Commit Type

  • Exactly one type selected: fix - Bug fix.
  • This matches the change: replacing the global ext.defaultLogicAppPath with explicitly resolved per-project paths so Data Mapper commands work in multi-project workspaces.

Risk Level

  • Medium is selected in the body and the risk:medium label is present — both match, and this aligns with the advised estimate. The change affects the shipped VS Code extension distribution (apps/vs-code-designer) and reworks how Data Mapper commands resolve project paths, which is moderate user-facing impact but not security/breaking-API scope.

What & Why

  • Current: Explains removing ext.defaultLogicAppPath and resolving projectPath via automatic selection, command context, or prompt, with rationale about multi-project workspaces.
  • Issue: None — clear and specific.
  • Recommendation: No changes needed.

Impact of Change

  • All three audiences are addressed (Users, Developers: N/A, System: N/A), which is acceptable.
  • Recommendation:
    • Users: Fixes Data Mapper commands in workspaces with multiple projects.
    • Developers: DataMapperExt.openDataMapperPanel/DataMapperPanel now require a projectPath; panel keys are composite (projectPath::dataMapName).
    • System: No architecture/dependency changes.

Test Plan

  • Unit tests added/updated (confirmed in diff: new DataMapperExt.test.ts and DataMapperPanel.test.ts) plus manual testing checked. Automated coverage requirement satisfied.

Contributors

  • @andrew-eldridge credited.

Screenshots/Videos

  • Not required — changes are to extension backend/command logic in apps/vs-code-designer/src, not visual UI in designer-ui/designer/vs-code-react.

Summary Table

Section Status Recommendation
Title No changes needed
Commit Type No changes needed
Risk Level Medium is correct
What & Why No changes needed
Impact of Change No changes needed
Test Plan Unit tests present
Contributors No changes needed
Screenshots/Videos Not applicable

✅ All checks pass — this PR is compliant with the team template and cleared to merge.


Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Tue, 01 Sep 2026 18:56:40 GMT

@andrew-eldridge Andrew Eldridge (andrew-eldridge) added risk:medium Medium risk change with potential impact and removed risk:low Low risk change with minimal impact needs-pr-update labels Sep 1, 2026
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage Check

The following changed files need attention:

apps/vs-code-designer/src/app/commands/dataMapper/dataMapper.ts - 0% covered

⚠️ apps/vs-code-designer/src/app/commands/dataMapper/DataMapperExt.ts - 36% covered (needs improvement)
⚠️ apps/vs-code-designer/src/app/commands/dataMapper/DataMapperPanel.ts - 46% covered (needs improvement)

Please add tests for the uncovered files before merging.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the global default Logic App path and scopes Data Mapper operations to an explicitly resolved project.

Changes:

  • Resolve the project path per Data Mapper command.
  • Pass the path through panel creation and runtime startup.
  • Use the panel’s project path for file operations.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
main.ts Removes default-project initialization.
extensionVariables.ts Removes global project-path state.
DataMapperPanel.ts Scopes operations to the panel’s project.
DataMapperExt.ts Propagates project paths during panel creation.
dataMapper.ts Resolves project paths when commands run.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread apps/vs-code-designer/src/app/commands/dataMapper/DataMapperExt.ts
Comment thread apps/vs-code-designer/src/app/commands/dataMapper/dataMapper.ts
Comment thread apps/vs-code-designer/src/main.ts
@andrew-eldridge
Andrew Eldridge (andrew-eldridge) merged commit ebf2653 into main Sep 1, 2026
37 of 45 checks passed
@andrew-eldridge
Andrew Eldridge (andrew-eldridge) deleted the aeldridge/vscode-remove-default-la branch September 1, 2026 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:medium Medium risk change with potential impact VSCode Issues or PRs specific to VS Code extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants