Skip to content

fix(vs-code-designer): update agent CodeLens LSP bundle - #9577

Merged
Brian Lam (lambrianmsft) merged 6 commits into
Azure:mainfrom
lambrianmsft:lambrianmsft-ux-agent-codelens-tests
Sep 2, 2026
Merged

fix(vs-code-designer): update agent CodeLens LSP bundle#9577
Brian Lam (lambrianmsft) merged 6 commits into
Azure:mainfrom
lambrianmsft:lambrianmsft-ux-agent-codelens-tests

Conversation

@lambrianmsft

@lambrianmsft Brian Lam (lambrianmsft) commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Commit Type

  • feature - New functionality
  • fix - Bug fix
  • refactor - Code restructuring without behavior change
  • perf - Performance improvement
  • docs - Documentation update
  • test - Test-related changes
  • chore - Maintenance/tooling

Risk Level

  • Low - Minor changes, limited scope
  • Medium - Moderate changes, some user impact
  • High - Major changes, significant user/system impact

What & Why

Updates the bundled LSPServer.zip with the agent CodeLens fix from logicapps-sdk-lsp-server and adds regression coverage for generated codeful agent source using the current singular WorkflowActions.BuiltIn.Agent(...) SDK API. This prevents the codeful agent create/manage connection CodeLens from regressing back to removed AgentBuilder / builder patterns.

Impact of Change

  • Users: Codeful agent workflows can surface the agent connection CodeLens for the current SDK API shape.
  • Developers: Codeful agent templates/tests now assert WorkflowActions.BuiltIn.Agent(...) and reject removed SDK patterns.
  • System: Bundled LSP server archive is refreshed and ships within the VS Code extension; no runtime workflow behavior changes.

Test Plan

  • Unit tests added/updated
  • E2E tests added/updated
  • Manual testing completed
  • Tested in: npx biome check --write apps\vs-code-designer\src\app\languageServer\__test__\bundledLspServerCodeLens.test.ts apps\vs-code-designer\src\app\commands\createNewCodeProject\CodeProjectBase\__test__\CreateLogicAppWorkspace.test.ts apps\vs-code-designer\src\app\utils\__test__\codeful.test.ts; pnpm --dir apps\vs-code-designer run test:extension-unit -- bundledLspServerCodeLens.test.ts CreateLogicAppWorkspace.test.ts codeful.test.ts (99/99 passed); copied LSPServer.zip was expanded and verified to contain SdkLspServer.dll.

Contributors

Brian Lam (@lambrianmsft)

Screenshots/Videos

N/A

Copilot AI balanced review requested due to automatic review settings August 26, 2026 23:15
Update the bundled LSPServer.zip and add codeful agent regression tests for the current WorkflowActions.BuiltIn.Agent SDK pattern.

Co-authored-by: Copilot App <[email protected]>
@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

🤖 AI PR Validation Report

PR Review Results

Thank you for your submission! Here's detailed feedback on your PR title and body compliance:

PR Title

  • Current: fix(vs-code-designer): update agent CodeLens LSP bundle
  • Issue: None — uses a valid fix(scope): prefix and is descriptive.
  • Recommendation: No change needed.

Commit Type

  • Exactly one type selected (fix - Bug fix).
  • Matches the title prefix and the nature of the change (bundled LSP fix + regression tests).

Risk Level

  • Declared Medium (body) and label risk:medium — both agree. This matches the advised estimate: the change refreshes the bundled LSPServer.zip that ships within the apps/vs-code-designer extension distribution, which the rubric classifies as Medium. Correctly declared.

What & Why

  • Current: Explains the LSP bundle refresh, the agent CodeLens fix, and added regression coverage for the singular WorkflowActions.BuiltIn.Agent(...) API.
  • Issue: None.
  • Recommendation: No change needed.

Impact of Change

  • All three audiences addressed (Users, Developers, System) with concrete detail.
  • Recommendation:
    • Users: Clearly stated.
    • Developers: Clearly stated.
    • System: Clearly stated.

Test Plan

  • Unit tests added/updated is checked and confirmed in the diff: new bundledLspServerCodeLens.test.ts, plus additions to CreateLogicAppWorkspace.test.ts and codeful.test.ts. Passes CHECK TESTS.

Contributors

  • @lambrianmsft credited.

Screenshots/Videos

  • Marked N/A. The diff touches only apps/vs-code-designer (tests, bundled asset, E2E helpers) — no libs/designer-ui/src, libs/designer/src, or apps/vs-code-react UI. No screenshots required.

Summary Table

Section Status Recommendation
Title No change needed
Commit Type No change needed
Risk Level Medium is correct (extension distribution)
What & Why No change needed
Impact of Change No change needed
Test Plan No change needed
Contributors No change needed
Screenshots/Videos N/A — no visual changes

All checks pass. This PR is compliant with the team template and cleared to merge.


Powered by: Copilot CLI (claude-opus-4.8) | Last updated: Tue, 01 Sep 2026 23:38:56 GMT

@lambrianmsft Brian Lam (lambrianmsft) changed the title Update agent CodeLens LSP bundle fix(vs-code-designer): update agent CodeLens LSP bundle Aug 26, 2026
@lambrianmsft Brian Lam (lambrianmsft) added risk:medium Medium risk change with potential impact and removed needs-pr-update labels Aug 26, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the bundled LSP server to support CodeLens for current codeful agent APIs.

Changes:

  • Refreshes LSPServer.zip.
  • Adds current-agent API detection and template regression tests.
  • Rejects legacy builder patterns.

Readiness concern: The tests do not exercise CodeLens against the bundled server. The title also lacks the required prefix.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
apps/vs-code-designer/src/assets/LSPServer/LSPServer.zip Updates the bundled language server.
apps/vs-code-designer/src/app/utils/__test__/codeful.test.ts Adds agent-source detection tests.
apps/vs-code-designer/src/app/commands/createNewCodeProject/CodeProjectBase/__test__/CreateLogicAppWorkspace.test.ts Strengthens generated-template assertions.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread apps/vs-code-designer/src/app/utils/__test__/codeful.test.ts
Add a focused integration test that extracts the committed LSPServer.zip, launches SdkLspServer.dll over stdio, and verifies the current WorkflowActions.BuiltIn.Agent source returns create/manage agent connection CodeLens results.

Co-authored-by: Copilot App <[email protected]>
@lambrianmsft
Brian Lam (lambrianmsft) merged commit 3ed4efd into Azure:main Sep 2, 2026
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-validated risk:medium Medium risk change with potential impact

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants