Repository navigation
Ask gallery-dl first for Facebook posts - #18
Merged
Merged
Conversation
yt-dlp, which went first for every Facebook link, took a short video from the page of a post with a picture, and the pack had that video instead of the picture. Facebook posts now go to gallery-dl first, as Instagram does; reels and videos still go to yt-dlp first.
stefan-azentrius
added a commit
that referenced
this pull request
Oct 26, 2026
…#19) ## Summary Prepares the release 0.1.2 with everything on `main` since 0.1.1 (#7 to #18). - `__version__` in `app/__init__.py`: 0.1.1 to 0.1.2. The image label, the extension's manifest and the version on the page follow from it. - `CHANGELOG.md`: the section "Unreleased" becomes "0.1.2 – 2026-10-26", with a summary that now names the Facebook posts with pictures (#17, #18). The "Upgrading" note names the extension zip the release workflow attaches. After the merge, the `release` workflow builds the source archive, `sharewerk-extension-0.1.2.zip` and the image `ghcr.io/azentrius/sharewerk:0.1.2`, each with build provenance, and takes the notes from this section. ## Test - `tools/release-notes.sh 0.1.2` prints the section (54 lines). - Locally: ruff clean, pytest 167 passed and 3 skipped (no FFmpeg), node --test 35 of 35 (app, extension, PWA update), `git diff --check` clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #17, a Facebook post with an article picture came back as a pack with a short video (3 seconds of sound) instead of the picture. yt-dlp, which goes first for every Facebook link, took a video from the post's page; an hour earlier it had found no video there at all. The check on the server for #17 showed that gallery-dl finds exactly the post's one picture.
kind == "post", e.g. resolvedstory.php,permalink.phpand<id>/posts/<id>links) now go to gallery-dl first, as Instagram does, with the post link from Hand Facebook photo posts to gallery-dl as post links #17. yt-dlp only runs when gallery-dl finds nothing, e.g. for a post with a video only, and gets the original link./reel/,/watch,/videos/) still go to yt-dlp first.Test
tests/test_fetch.py:git diff --checkclean.