fix(tests): quote the paths in runE2ETestPipeline's g++ command - #226
Open
MatthewReed303 wants to merge 1 commit into
Open
fix(tests): quote the paths in runE2ETestPipeline's g++ command#226MatthewReed303 wants to merge 1 commit into
MatthewReed303 wants to merge 1 commit into
Conversation
The argv array was joined into a shell string with nothing quoted, so a repo path containing a space word-split the -I flags and 115 tests failed. Quoted in the style the neighbouring call sites already use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runE2ETestPipelinebuilt its g++ command byjoin(' ')-ing an argv array intoa shell string and quoted nothing, so any repo path containing a space
word-split the
-Iflags and backgrounded the command at an&.under such a path.
(
:93,:156, andoscat-gpp-compile.test.ts:185-193). No behaviour changewhere the path has no spaces.