Skip to content

Synchronize native MariaDB abort coverage #2445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chubes4 merged 1 commit into from
Aug 31, 2026
Merged

Synchronize native MariaDB abort coverage #2445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions tests/native-mariadb-runtime-service.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,14 +284,24 @@ process.exit(1);
const allAbortFirst = new AbortController()
const allAbortSecond = new AbortController()
const beforeAllAbort = singleFlightAllocations()
const allAbortFirstResult = nativeMariaDbHostReadiness(dependencies, allAbortFirst.signal)
const allAbortSecondResult = nativeMariaDbHostReadiness(dependencies, allAbortSecond.signal)
while (singleFlightAllocations() === beforeAllAbort) await abortableDelay(10)
let allAbortAllocationEntered!: () => void
const allAbortAllocationStarted = new Promise<void>((resolve) => { allAbortAllocationEntered = resolve })
const allAbortDependencies: RuntimeServiceDependencies = { ...dependencies, async execute(command, args, options) {
const result = await dependencies.execute(command, args, options)
if (options.stdin?.includes("CREATE DATABASE")) {
allAbortAllocationEntered()
await abortableDelay(1_000, options.signal)
}
return result
} }
const allAbortFirstResult = nativeMariaDbHostReadiness(allAbortDependencies, allAbortFirst.signal)
const allAbortSecondResult = nativeMariaDbHostReadiness(allAbortDependencies, allAbortSecond.signal)
await allAbortAllocationStarted
allAbortFirst.abort()
allAbortSecond.abort()
assert.deepEqual(await allAbortFirstResult, { status: "unavailable", reason: "containment-probe-interrupted" })
assert.deepEqual(await allAbortSecondResult, { status: "unavailable", reason: "containment-probe-interrupted" })
await settleNativeMariaDbHostReadiness(dependencies)
await settleNativeMariaDbHostReadiness(allAbortDependencies)
assert.equal(singleFlightAllocations(), beforeAllAbort + 1, "all aborted waiters cancel only one underlying allocation")
assert.deepEqual((await readdir(tmpdir())).filter((name) => name.startsWith("wp-codebox-mariadb-") && !allAbortRoots.has(name)), [], "all-waiter abort cleans the underlying allocation")
assert.equal(getEventListeners(allAbortFirst.signal, "abort").length + getEventListeners(allAbortSecond.signal, "abort").length, 0)
Expand Down
Loading