Skip to content

Give labeled navigation sections one owner - #1503

Merged
chubes4 merged 1 commit into
trunkfrom
refactor/navigation-pattern-owner
Sep 1, 2026
Merged

Give labeled navigation sections one owner#1503
chubes4 merged 1 commit into
trunkfrom
refactor/navigation-pattern-owner

Conversation

@chubes4

@chubes4 chubes4 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • move labeled non-nav navigation-section recognition from HtmlTransformer into NavigationPattern
  • replace the flow converter callback with a typed PatternContext dependency while preserving its original precedence
  • remove three navigation-only methods from the generic source classifier

This advances #242 by reducing decisions reachable through HtmlTransformer rather than adding another engine abstraction. HtmlTransformer loses 57 lines and one method, closure context fields drop from 264 to 263, and production code decreases by 10 lines.

Verification

  • composer test
  • 292 PHP parity fixtures passed
  • 385 HTML fixtures: 0 serialized-block hash differences, 0 exceptions
  • focused regressions cover labeled social-link precedence and exact classifier boundaries

AI assistance

OpenAI GPT-5.6 Sol via OpenCode mapped the conversion architecture, implemented the navigation ownership consolidation under Chris Huber's direction, performed dedicated precedence reviews, and ran the full verification suite.

@chubes4
chubes4 merged commit 2dbbbc5 into trunk Sep 1, 2026
10 checks passed
@chubes4
chubes4 deleted the refactor/navigation-pattern-owner branch September 1, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant