Reserve no editor height for withheld group pickers - #1490
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Painted source layers materialize as empty
core/groupblocks. In the editor, core renders its empty-group variation picker inside them, so an earlier change withheld that picker. The placeholder still reservedmin-height: 2remfor it, which is height the source layer never occupies: on the frontend these layers are painted out of normal flow.Measured in the editor canvas of a generated site, four such placeholders sit consecutively at the top of the document:
That is 128px of displacement applied before any authored content, which pushes the hero and everything after it down the canvas. The frontend is unaffected, so the editor and the rendered page disagree about where the composition starts.
Change
Reserve no height for a picker that is withheld. The placeholder keeps its normal-flow bounding (
position:relative; inset:auto) so it cannot escape the canvas, and takesmin-height: 0so it displaces nothing.Verification
AI assistance disclosure
Implemented with AI assistance: Claude Sonnet 4.5 running in the opencode CLI agent. The AI measured the placeholder geometry in a live editor canvas, identified the reserved height as the displacement source, made the change, and ran the suite. A human reviewed and directed the work.