Repository navigation
feat(jobadder): add job attachment file actions - #529
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
🔍 Integration Validation ResultsCommit:
|
![autohive-ai[bot]](https://avatars.githubusercontent.com/in/4787664?s=60&v=4){kind=small}
There was a problem hiding this comment.
| Result | P1 | P2 | P3 |
|---|---|---|---|
| Clean review | 0 | 0 | 0 |
Clean review
Summary
Reviewed commit: e385e29
No actionable issues found in the job attachment actions, schemas, or shared download refactor.
For an explanation, reply under a comment with @autohiveai and your question.
Limitations
- Tests were not run, as requested.
- Live JobAdder behavior and the platform chat-file handoff were not exercised.
Review powered by Autohive
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e385e29177
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| params = { | ||
| key: value | ||
| for key, value in { | ||
| "type": inputs.get("types"), |
There was a problem hiding this comment.
When callers select both types, _fetch_get serializes this list as ?type=Other&type=JobDescription, and the new category action does the same. The JobAdder API reference declares type on both job-attachment endpoints with CSV collection format, so these actions need to send type=Other,JobDescription; otherwise JobAdder may reject the request or apply only one selected type. Pass these particular arrays as comma-separated scalar values rather than through the generic repeated-parameter encoding.
Useful? React with 👍 / 👎.
Integration tests✅ JobAdder (14/14 tests pass, 43 skipped)Skipped (43) Passed (14) |
|
The code review feedback on scopes is a false positive. We need the scopes The version number bump, I will need Kai to check this please! @TheRealAgentK |
Edit: I misread the code - the changes are entirely in internal functions, sorry for any confusion, @sumitramanga . Version can stay with what you changed it to. |
2 participants
Description 📝
list_job_attachmentswith type/latest filters. Generalised the candidate attachment download and size-limit helpers so both attachment types share them. Added thewrite_jobOAuth scope. Bumped integration version to 1.2.0.Type of change
Updates
👉 New actions:
list_job_attachment_categories,download_job_attachment(up to 5 MiB, returned as an Autohive file object),upload_job_attachmentandupdate_job_attachment👉
list_job_attachmentsnow acceptstypesandlatestfilters; shared_download_attachmenthelper andMAX_ATTACHMENT_BYTESreplace the candidate-specific versions👉 Added
write_jobscope toconfig.json; README updated with the new actions, scope and limitationsScreenshots 📷
{Image here of before and after - if applicable}
Test plan 🧪
Provide guidance for how to QA your proposed changes. This is not only for a test but also useful for a reviewer.
{A test plan outlining scenarios to test}
Author(s) to check 👓