Repository navigation
feat(release): add deployment manifest commands - #62
Conversation
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
There was a problem hiding this comment.
| Verdict | Errors | Warnings | Suggestions |
|---|---|---|---|
| Reviewed | 0 | 1 | 0 |
Reviewed
Summary
PR adds hiveup release-plan/release-manifest commands and a new release.py module that resolves a safe integration selection and writes a checksummed deployment manifest with GitHub provenance; version bumped to 2.5.0 throughout. Static review of the diff and the checked-out repo found the logic sound overall (path/identity validation, duplicate detection, and safe selection resolution all check out), but dynamic test execution wasn't possible because pip install -e . failed offline on the private autohive-integrations-sdk dependency, so tests/test_release.py could not be run in this environment.
Observations
- Both new CLI commands only catch
ReleaseManifestError(cli.py lines ~310, ~344); any other exception raised fromrelease.py(e.g. a nonexistent--repository-root, which raisesFileNotFoundErrorfromiterdir()) will surface as a raw Python traceback instead of the clean, exit-code-2 error UX the rest of the command demonstrates. Consider validating/normalizing inputs earlier or widening the except clause at the CLI boundary.
Review powered by Autohive
TheRealAgentK
left a comment
There was a problem hiding this comment.
Approved. No blocking correctness findings in the release selection, manifest generation, SDK-floor enforcement, packaging, or version-bump changes. Verified the reviewed head with 217 passing tooling tests and all five companion workflow-selection tests. The history-recovery finding on integrations PR #441 belongs to that workflow and does not block this tooling PR.
Closes #61
Depends on no other pipeline PR and should merge first.
Summary
release-planfor safe manual selection by repository pathrelease-changesto select only new integrations or integrations whose semantic version increased from a supplied Git commitsource_idconfigurationautohive-integrations-sdk>=1.0.2during packaging, including--skip-validatepreserve,zip, andcontainerpackage-type requestsFlow
flowchart LR A[Previous master SHA] --> B[release-changes] C[Current checkout] --> B B --> D{New path or version bump?} D -->|No| E[No release] D -->|Yes| F[Selected repository paths] F --> G[Package with SDK floor] G --> H[Schema 3 SHA-256 manifest]Testing
uv run pytest -q(180 passed, 18 skipped)autohive_integrations_sdkrelease-changesselected onlymicrosoft365for the latest version-bump range in the integrations repositoryRollout
2.5.0from the merge commit.2.5.0.