fix(mobile): uniform contest tile height in horizontal scroll row - #14540
Open
dylanjeffers wants to merge 2 commits into
Open
fix(mobile): uniform contest tile height in horizontal scroll row#14540dylanjeffers wants to merge 2 commits into
dylanjeffers wants to merge 2 commits into
Conversation
Cards with a one-line title were shorter than cards with a two-line title, making explore/home carousels look uneven. Fix: wrap the grid-variant title Text in a View with minHeight: 64 (2 × lineHeight-xl = 2 × 32px for heading/m). Single-line titles now reserve space for a second line, so all tiles in a row share the same height. The hero variant (full-width) is left unconstrained since it is never shown beside another card.
|
…rousel
ContestCardSkeleton was passed style={{ width: contestCardWidth }}, the
full slot width. CardList wraps each horizontal item in a View with
paddingRight: spacing(3) to create the gap between cards. Real
ContestCards have no explicit width so they stretch to fill the content
area (slot width minus padding), making the gap visible. The explicit
width on the skeleton overrode that stretching and caused it to bleed
into the adjacent slot, erasing the gap entirely.
Fix: remove the explicit width from the LoadingCardComponent; the
skeleton now fills its container the same way a real card does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contest cards in the Explore carousel were different heights when a title wrapped to two lines vs one line, making the row look uneven. Fix: wrap the grid-variant title Text in a View with minHeight 64 (2 x lineHeight-xl = 2 x 32px for heading/m). Single-line titles now reserve space for a second line. Hero variant left unconstrained. Pure layout change, no data or API logic touched.