Bump @xmldom/xmldom from 0.8.13 to 0.8.15

[dependabot]

Bumps @xmldom/xmldom from 0.8.13 to 0.8.15.

Release notes

Sourced from @​xmldom/xmldom's releases.

0.8.15

Commits

Fixed

• Security: parsing a deeply or repeatedly namespaced document no longer consumes quadratic memory; the in-scope namespace map is inherited through the prototype chain instead of being copied for every prefix-declaring element (O(N) instead of O(N²)), preventing a denial-of-service reachable from DOMParser.parseFromString with default options. Serialized output is byte-identical. GHSA-965w-775f-mr7g
• Security: attribute de-duplication during parsing is now O(M) instead of O(M²); the NamedNodeMap parse-time dedup path uses a null-prototype membership index, so a well-formed document with a hostile number of duplicate attributes can no longer wedge the parse. Attribute order and duplicate resolution (last value wins, first position kept) are byte-identical, preserving the XML no-duplicate-attributes well-formedness constraint. GHSA-8344-3jmq-59r6
• Security: trimming trailing whitespace from an XML end tag (ETag) is now anchored so it runs in linear time instead of backtracking quadratically on a long whitespace run, preventing a ReDoS reachable from DOMParser.parseFromString. Trimmed output is byte-identical. GHSA-x4fp-j954-r2f4
• Security: malformed-input recovery is now linear instead of quadratic — the malformed tag-name scan terminates at an embedded <, and Node.prototype.normalize() merges adjacent text nodes in O(K) instead of O(K²) (also reachable programmatically), per normalize() in the WHATWG DOM spec. DOM output is unchanged; only the reported error text differs. GHSA-93r5-fhx6-vmg9
• Security: XMLSerializer.serializeToString() under { requireWellFormed: true } now rejects a DocType name that is not a valid XML Name, throwing InvalidStateError — matching the sibling publicId/systemId/internalSubset checks and preventing XML injection via DocumentType.name. GHSA-27p8-2357-5qqv
• Security: XMLSerializer.serializeToString() under { requireWellFormed: true } now validates a processing-instruction target as an XML NCName and rejects a case-insensitive xml, throwing InvalidStateError — a check 0.8.x did not previously perform, preventing PI-target injection via >, ?, or whitespace. GHSA-c7q8-3ch8-vqpv
• Security: Document.createEntityReference() now rejects an invalid XML Name at creation, and XMLSerializer.serializeToString() under { requireWellFormed: true } validates an EntityReference nodeName as an XML Name, throwing InvalidStateError — preventing XML injection via an entity-reference name. GHSA-6gmq-8vp8-gcm6
• Security: the parser now reports a not-well-formed end tag whose valid name is followed by trailing content as a recoverable error instead of accepting it silently, per the XML ETag production; parsing recovers to the byte-identical DOM. Consumers that want strict rejection can escalate the reported error to fatal via the parser's errorHandler. GHSA-6h8r-xr42-gp59

Thank you, @​ericchiang, @​bhaswanthc, @​arpitjain099, @​Paranoidgrinch, for your contributions

0.8.14

Commits

Fixed

• Security: XMLSerializer.serializeToString() now also rejects invalid element and attribute names when { requireWellFormed: true } is passed, throwing InvalidStateError for a name that is not a valid XML QName (this covers the namespace prefix, which surfaces in the element qualified name or in a synthesized xmlns: declaration). This prevents XML injection via createElement() / setAttribute(), extending the existing requireWellFormed checks to the serialized name set. GHSA-w2rr-34g9-rvrj GHSA-4w3w-2rp5-g8jm

Thank you, @​bhaswanthc, @​jmestwa-coder, for your contributions

Changelog

Sourced from @​xmldom/xmldom's changelog.

0.8.15

Fixed

• Security: parsing a deeply or repeatedly namespaced document no longer consumes quadratic memory; the in-scope namespace map is inherited through the prototype chain instead of being copied for every prefix-declaring element (O(N) instead of O(N²)), preventing a denial-of-service reachable from DOMParser.parseFromString with default options. Serialized output is byte-identical. GHSA-965w-775f-mr7g
• Security: attribute de-duplication during parsing is now O(M) instead of O(M²); the NamedNodeMap parse-time dedup path uses a null-prototype membership index, so a well-formed document with a hostile number of duplicate attributes can no longer wedge the parse. Attribute order and duplicate resolution (last value wins, first position kept) are byte-identical, preserving the XML no-duplicate-attributes well-formedness constraint. GHSA-8344-3jmq-59r6
• Security: trimming trailing whitespace from an XML end tag (ETag) is now anchored so it runs in linear time instead of backtracking quadratically on a long whitespace run, preventing a ReDoS reachable from DOMParser.parseFromString. Trimmed output is byte-identical. GHSA-x4fp-j954-r2f4
• Security: malformed-input recovery is now linear instead of quadratic — the malformed tag-name scan terminates at an embedded <, and Node.prototype.normalize() merges adjacent text nodes in O(K) instead of O(K²) (also reachable programmatically), per normalize() in the WHATWG DOM spec. DOM output is unchanged; only the reported error text differs. GHSA-93r5-fhx6-vmg9
• Security: XMLSerializer.serializeToString() under { requireWellFormed: true } now rejects a DocType name that is not a valid XML Name, throwing InvalidStateError — matching the sibling publicId/systemId/internalSubset checks and preventing XML injection via DocumentType.name. GHSA-27p8-2357-5qqv
• Security: XMLSerializer.serializeToString() under { requireWellFormed: true } now validates a processing-instruction target as an XML NCName and rejects a case-insensitive xml, throwing InvalidStateError — a check 0.8.x did not previously perform, preventing PI-target injection via >, ?, or whitespace. GHSA-c7q8-3ch8-vqpv
• Security: Document.createEntityReference() now rejects an invalid XML Name at creation, and XMLSerializer.serializeToString() under { requireWellFormed: true } validates an EntityReference nodeName as an XML Name, throwing InvalidStateError — preventing XML injection via an entity-reference name. GHSA-6gmq-8vp8-gcm6
• Security: the parser now reports a not-well-formed end tag whose valid name is followed by trailing content as a recoverable error instead of accepting it silently, per the XML ETag production; parsing recovers to the byte-identical DOM. Consumers that want strict rejection can escalate the reported error to fatal via the parser's errorHandler. GHSA-6h8r-xr42-gp59

Thank you, @​ericchiang, @​bhaswanthc, @​arpitjain099, @​Paranoidgrinch, for your contributions

0.9.11

Fixed

• Security: XMLSerializer.serializeToString() now also rejects invalid element and attribute names when { requireWellFormed: true } is passed, throwing InvalidStateError for a name that is not a valid XML QName (this covers the namespace prefix, which surfaces in the element qualified name or in a synthesized xmlns: declaration). This prevents XML injection via createElement() / setAttribute(), extending the existing requireWellFormed checks to the serialized name set. GHSA-w2rr-34g9-rvrj GHSA-4w3w-2rp5-g8jm
• Security: the processing-instruction grammar regex no longer backtracks quadratically on an unterminated processing instruction (<?… with no closing ?>), preventing a denial-of-service (ReDoS) reachable from DOMParser.parseFromString with default options. GHSA-g53g-w8rj-fmg7
• CharacterData nodeValue and data are now kept in sync [#990](https://github.com/xmldom/xmldom/issues/990)

Chore

• updated dependencies

Thank you, @​bhaswanthc, @​jmestwa-coder, @​stevenobiajulu, for your contributions

0.8.14

Fixed

• Security: XMLSerializer.serializeToString() now also rejects invalid element and attribute names when { requireWellFormed: true } is passed, throwing InvalidStateError for a name that is not a valid XML QName (this covers the namespace prefix, which surfaces in the element qualified name or in a synthesized xmlns: declaration). This prevents XML injection via createElement() / setAttribute(), extending the existing requireWellFormed checks to the serialized name set. GHSA-w2rr-34g9-rvrj GHSA-4w3w-2rp5-g8jm

Thank you, @​bhaswanthc, @​jmestwa-coder, for your contributions

0.9.10

... (truncated)

Commits

• b5b8fb5 0.8.15
• 327508e docs: add 0.8.15 CHANGELOG entry
• f40ccb8 fix: prevent quadratic malformed-tag recovery and normalize() adjacent-text m...
• 3abb093 fix: prevent end-tag whitespace-trim ReDoS via anchored trim (GHSA-x4fp-j954-...
• 2c548f2 fix: prevent quadratic attribute de-duplication via null-prototype membership...
• 08a74b4 test: characterize NamedNodeMap attribute de-duplication before the index ref...
• 954370f fix: prevent quadratic namespace-map memory consumption via prototype-chain i...
• 4430189 fix: report not-well-formed end-tag trailing content (GHSA-6h8r-xr42-gp59)
• 6c3fb5f fix: prevent XML injection via unsafe EntityReference name (GHSA-6gmq-8vp8-gcm6)
• 3b69487 fix: prevent XML injection via unsafe processing instruction target serializa...
• Additional commits viewable in compare view

Maintainer changes

This version was pushed to npm by karfau, a new releaser for @​xmldom/xmldom since your current version.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  You can disable automated security fix PRs for this repo from the Security Alerts page.

[atlas-commons-bot]

Atlas Commons PR review

Requirement	Status
DCO sign-off	fail
Required checks	fail
Summary filled	fail
Checklist	pass
Linked issue	warn

Overall: fail

• Missing Signed-off-by on: 65ad099
• Required checks failed.
• Summary section is empty or still has placeholder text.
• All checklist items ticked or none present.
• No linked issue (advisory).

View PR #27 · Atlas-Commons/StreamBooru

[atlas-commons-bot]

Atlas Commons code review (LLM)

Summary

This PR bumps the transitive @xmldom/xmldom lockfile resolution from 0.8.13 → 0.8.15 in package-lock.json. The package is not a direct dependency; it is pulled in by [email protected], which is used at dev/build time by @capacitor/cli and electron-builder (via app-builder-lib) to parse Apple .plist XML during Android/iOS/macOS packaging.

The upgrade addresses multiple moderate-severity advisories in 0.8.14–0.8.15 (quadratic-memory/CPU DoS in DOMParser.parseFromString, and stricter serialization validation under requireWellFormed). The diff is minimal and appropriate for a Dependabot security update.

Important scope note: runtime Gelbooru XML parsing in renderer/js/booru-client.js uses the browser/Electron DOMParser, not @xmldom/xmldom. This bump does not change that code path.

Potential issues

1. DCO sign-off will block merge. The repo requires Signed-off-by on every commit (.github/CONTRIBUTING.md, ci.github.yml DCO job). Dependabot commits typically lack this trailer, and the PR context already reports a failure on 65ad099. Branch protection’s “Required checks” aggregate job will stay red until DCO is satisfied or a maintainer rebases/amends with -s.

2. PR template/process gaps. The PR description still has placeholder/template content (empty Summary checklist items). That does not affect correctness but contributes to the failed required-checks signal and makes audit trail harder for future reviewers.

3. Separate runtime XML attack surface remains. Gelbooru fallback parsing in booru-client.js feeds untrusted remote XML into the Chromium renderer DOMParser. That path is outside this dependency and is not remediated by bumping @xmldom/xmldom:

return [...new DOMParser().parseFromString(xml, 'text/xml').getElementsByTagName('post')]

If Gelbooru XML fallback is still used in production, hardening or strict size limits on that response deserve a follow-up issue—not a reason to reject this PR, but worth tracking.

4. Build-time DoS fixes are the main practical win here. plist uses @xmldom/xmldom only for trusted local plist files during build (node_modules/plist/lib/parse.js). Runtime end-user exposure is low, but CI/build machines parsing plist XML still benefit from the 0.8.15 complexity fixes. No functional plist parsing changes are expected (release notes claim byte-identical DOM/serialization for the fixed paths).

Suggestions

• Resolve DCO before merge: maintainer cherry-pick/rebase with git commit -s --amend, or merge via a signed maintainer commit that updates the lockfile. Confirm the DCO and “Required checks” jobs go green.
• Verify with the same commands CI runs: npm ci, then npm run webapp:build, webapp:check, and the smoke tests in .github/workflows/ci.github.yml. This change should not require app code changes.
• Optional hardening: add an overrides entry in package.json to pin @xmldom/xmldom at 0.8.15, making the security intent explicit and keeping future lockfile regenerations on the patched line while plist remains on ^0.8.8.
• Optional follow-up: run npm audit after merge to confirm the moderate @xmldom/xmldom advisory clears (it should on 0.8.15).

Overall assessment

Low-risk, high-value security maintenance. The lockfile-only diff is correct; plist’s semver range already permits 0.8.15, and the advisories fixed between 0.8.13 and 0.8.15 are relevant even for dev/build tooling. I would support merging once DCO and CI are green. No application code changes appear necessary; the main blockers are process (sign-off, checklist), not the dependency bump itself.

---

Advisory review only — not a merge approval.

View PR #27 · Atlas-Commons/StreamBooru