Repository navigation
Set the CRS of DINO GeoDataFrames to EPSG:28992 - #62
Merged
Merged
Conversation
Collaborator
|
Looks good, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #61: the GeoDataFrames of the DINO functions now have a CRS (EPSG:28992), like those of the BRO functions.
dino.objects_to_gdfgets the same parameters asbro.objects_to_gdf:from_crs(the coordinate system of the coordinates in the data) andto_crs(of the result). Both default to 28992:X-coordinaat,Y-coordinaat, and the line geometry of the VES data derived from them) are in RD New;to_crs.The
CRScolumn of the DINO data is not used to determine the CRS: its value differs per data type (RD,RD2000,Rijksdriehoeksmeting), while all of them mean RD.As in
bro.objects_to_gdfandwebservices.py, no CRS is assigned when there is no geometry (e.g. no data found), because geopandas does not support a CRS without a geometry column.The callers of
objects_to_gdfare unchanged: the new parameters are at the end and have defaults.Tests: new
test_objects_to_gdf_crs(local file, also checksto_crs).tests/test_dino.pywith the file and extent tests passes locally (14 tests, including the VES, groundwater level and borehole sample downloads).