Skip to content

Set the CRS of DINO GeoDataFrames to EPSG:28992 - #62

Merged
rubencalje merged 1 commit into
ArtesiaWater:devfrom
MattBrst:dino-crs
Nov 11, 2026
Merged

rubencalje merged 1 commit into
ArtesiaWater:devfrom
MattBrst:dino-crs

Conversation

@MattBrst

@MattBrst MattBrst commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #61: the GeoDataFrames of the DINO functions now have a CRS (EPSG:28992), like those of the BRO functions.

dino.objects_to_gdf gets the same parameters as bro.objects_to_gdf: from_crs (the coordinate system of the coordinates in the data) and to_crs (of the result). Both default to 28992:

  • the coordinates in DINO (X-coordinaat, Y-coordinaat, and the line geometry of the VES data derived from them) are in RD New;
  • the result is in RD New, as for the BRO data, with the option to convert it with to_crs.

The CRS column of the DINO data is not used to determine the CRS: its value differs per data type (RD, RD2000, Rijksdriehoeksmeting), while all of them mean RD.

As in bro.objects_to_gdf and webservices.py, no CRS is assigned when there is no geometry (e.g. no data found), because geopandas does not support a CRS without a geometry column.

The callers of objects_to_gdf are unchanged: the new parameters are at the end and have defaults.

Tests: new test_objects_to_gdf_crs (local file, also checks to_crs). tests/test_dino.py with the file and extent tests passes locally (14 tests, including the VES, groundwater level and borehole sample downloads).

@MattBrst MattBrst changed the title Set the CRS of DINO GeoDataFrames to EPSG:28992, as for the BRO data Set the CRS of DINO GeoDataFrames to EPSG:28992 Nov 11, 2026
@rubencalje

Copy link
Copy Markdown
Collaborator

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DINO GeoDataFrames have no CRS (BRO GeoDataFrames are EPSG:28992)

2 participants