Skip to content

[codex] Export public decision settlement feedback - #8

Merged
HarcoChen merged 2 commits into
mainfrom
codex/public-settlement-feedback
Nov 14, 2026
Merged

HarcoChen merged 2 commits into
mainfrom
codex/public-settlement-feedback

Conversation

@HarcoChen

Copy link
Copy Markdown
Contributor

Motivation

Round-level reward research needs observed unit contributions and attributed economic outcomes after decisions. The existing decision ledger exposes public progress, while battle counters and economic provenance remain inside Core.

Changes

  • Export a public sideband feedback object from NativeSolo and NativeBatch, with decision/result revisions and per-transport receipts.
  • Bind settled battle reports to the completed round. Include source piece UIDs, summon ownership where available, measured damage, effective healing, HP loss taken, attack events and direct kill credits.
  • Preserve final counters of permanently removed allies in a bounded 4096-record buffer. Report dropped records and missing ownership explicitly.
  • Attribute actual miraShip and visiShip milestone funds, miraShip free-refresh grants, and investShip extra garrison invocations with observed currency deltas.
  • Expose the sideband through NativeLedgerEnv.feedback and NativeBatch info["feedback"]. Describe counter semantics and coverage in the README.

Coverage and limitations

Economic coverage is explicitly partial. investShip non-currency outcomes and other economic sources remain missing. Nested invocation deltas may include milestone payments that also have individual payment events, so downstream consumers need deduplication. Direct unit kills use deployment.kills and have a different scope from spawn-ledger creditedKills. Blocking count and duration remain unavailable. Counter retention completeness and implemented content coverage are separate concepts.

The feedback lives outside observation and policy encoding. This PR supplies measured feedback for subsequent diagnostics and research reward design.

Compilation

  • cargo check -p arkguard-python
  • cargo check --manifest-path crates/slots/Cargo.toml

Both compilation checks completed locally. The existing native-build pull-request workflow builds Linux, Windows and both macOS targets on Python 3.12.

@HarcoChen
HarcoChen marked this pull request as ready for review November 14, 2026 08:12
@HarcoChen
HarcoChen added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit 6746e7c Nov 14, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant