Skip to content

fix(installer): Ctrl-C at a menu exits under macOS bash 3.2 #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rob-archastro merged 1 commit into from
Oct 20, 2026
Merged

fix(installer): Ctrl-C at a menu exits under macOS bash 3.2 #77

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,19 @@ spin() {
# ---------------------------------------------------------------------------

CHOICE=0
KEY=""

# Read one key into KEY. bash 3.2 (macOS /bin/bash) restarts a read that a
# trapped SIGINT interrupts and runs the trap only once the read returns, so
# Ctrl-C at a menu would wait for another key. A one-second timeout lets the
# INT trap run between reads. End of input reads as Enter.
read_key() {
KEY=""
while :; do
IFS= read -rsn1 -t 1 KEY </dev/tty && return 0
[ "$?" -gt 128 ] || { KEY=""; return 0; }
done
}

# choose <question> <default index> <"Label|hint">...
# Arrow keys or j/k move, Enter selects, digits jump. Sets CHOICE.
Expand Down Expand Up @@ -375,8 +388,8 @@ choose() {
done
printf '\033[2K%s%s%s move %s select%s' "$PAD" "$C_DIM" "$(glyph '↑↓' 'j/k')" "$(glyph '↵' 'enter')" "$RESET"

key=""
IFS= read -rsn1 key </dev/tty || key=""
read_key
key="$KEY"
case "$key" in
"")
break
Expand Down
Loading