Repository navigation
fix(deps): bump certifi to 2026.10.19 for eMudhra CA distrust - #54
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
calvin-archastro
marked this pull request as draft
October 21, 2026 13:39
New npm advisories failed the "Audit JS tooling dependencies" CI step: - fast-uri override 4.1.4 -> 4.1.5 (GHSA-hrr3-gc8f-f4qj, GHSA-jvvf-x445-j334) - js-yaml override 5.2.3 -> 5.4.1 (GHSA-r3ph-w7gj-g6xm) - braces GHSA-vfj7-8cjw-p6xm has no patched release; waive until 2026-12-31. Only chokidar under prism-cli pulls it in, and it watches one fixed spec path with globbing disabled. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
calvin-archastro
marked this pull request as ready for review
October 21, 2026 13:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review on ArchCode
Problem
The eMudhra intermediate CA compromise (disclosed 2026-10-20, https://emudhra.we-have-a-problem.com) is fixed in certifi 2026.10.19 by removing the CA from the bundle.
uv.lockpins certifi 2026.2.25, so CI, dev environments anduv exported runtime requirements (hash-pinned wheel smoke test) still trust it.What changed
uv lock --upgrade-package certifiuv.lockonly (3 lines: version, sdist and wheel URLs/hashes). No transitive bumps.Audit JS tooling dependenciesstep on every CI job, so it is cleared here:fast-urioverride 4.1.4 -> 4.1.5 (GHSA-hrr3-gc8f-f4qj, GHSA-jvvf-x445-j334)js-yamloverride 5.2.3 -> 5.4.1 (GHSA-r3ph-w7gj-g6xm)bracesGHSA-vfj7-8cjw-p6xm: no patched release exists (all <= 3.0.3). Added a dated waiver (expires 2026-12-31) toscripts/audit-js-tooling.mjs. It reaches us only via chokidar 3.6.0 under@stoplight/prism-cli, which watches the one spec path we pass toprism mockwithdisableGlobbing: true, so braces never expands a pattern. Dev-only; not in the wheel.Scope
Backend-only: Python lockfile plus JS dev-tooling lockfile/overrides and the audit allowlist.
Risk
Low. certifi is a data-only package; the SDK does not pin it in
pyproject.toml, so installed users get whatever they resolve.User impact
Locked environments stop trusting the compromised intermediate. Users resolving their own dependencies should upgrade certifi themselves.
Testing
uv sync --locked --all-extras: passruff check,ruff format --check: passnode scripts/audit-js-tooling.mjs: clean (waived: GHSA-qxc2-j82w-r537, GHSA-vfj7-8cjw-p6xm)pytest tests/contract3036 passed (exercises Prism with the new js-yaml/fast-uri);pytest tests/harness tests/test_http_client.py src/archastro/phx_channel/tests/test_unit.py tests/examples117 passedpytest tests/harness tests/contract(ARCHASTRO_RUN_CHANNEL_CONTRACT_TESTS=1) and the unit/examples set from CI: pass (3042 and 3036 passed in the full runs; harness needsnpm ci --ignore-scriptsfirst)Follow-ups
🤖 Generated with Claude Code