feat(hid): rebind POP Keys' dedicated emoji keys - #726
Open
RafRaf wants to merge 1 commit into
Open
Conversation
Greptile SummaryThe PR makes four dedicated POP Keys emoji controls configurable through the existing HID++ keyboard-diversion path.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains.
|
| Filename | Overview |
|---|---|
| crates/openlogi-core/src/binding/button.rs | Adds four append-only emoji-key identifiers and includes them in the keyboard-key set without changing existing serialized identifiers. |
| crates/openlogi-core/src/binding/defaults.rs | Gives the new keyboard controls unbound defaults so their native behavior remains unless configured. |
| crates/openlogi-hid/src/session/keyboard.rs | Maps the four POP Keys control IDs into the existing capability-gated HID++ diversion and event-dispatch flow. |
| docs/config.example.toml | Adds a configuration example demonstrating a dedicated emoji-key binding. |
Reviews (2): Last reviewed commit: "feat(hid): rebind POP Keys' dedicated em..." | Re-trigger Greptile
Four of POP Keys' five dedicated emoji keys (heart-eyes, crying, smiley, tears) had no ButtonId at all, so they couldn't be rebound anywhere. Add them as KeyEmoji* variants, wire their CIDs (0x104-0x107) into the keyboard capture session's 0x1b04 diversion table, and default them to Action::None like every other keyboard key. Config-only for now, matching the existing 9 F-row keys: the GUI's Keys tab doesn't render any keyboard key of this kind yet.
RafRaf
force-pushed
the
feat/pop-keys-emoji-bindings
branch
from
August 20, 2026 20:57
033c559 to
fac0d46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I recently picked up a POP Keys keyboard and wanted to remap the emoji row the same way I remap everything else on my Logi gear (I've actually swapped in some of the spare keycaps it ships with, so what's printed on my keys right now isn't even the stock heart-eyes/crying/smiley/tears set — more on why that doesn't matter below). Turns out OpenLogi has no way to bind those keys at all — 4 of POP Keys' 5 dedicated emoji keys aren't modeled as a
ButtonIdanywhere. Only the "open emoji panel" key was already covered (KeyEmoji).This PR adds the missing four as new
ButtonIdvariants (KeyEmojiHeartEyes,KeyEmojiCrying,KeyEmojiSmiley,KeyEmojiTears) and wires their CIDs (0x104–0x107) into the0x1b04diversion table, so they're bindable inconfig.tomlthe same wayKeySearch/KeyDictation/etc. already are. The naming/binding is by HID++ control ID, not by whatever's printed on the cap — since POP Keys keycaps are swappable, that's the only thing that actually stays stable per key.I only did the config-side plumbing, not a dashboard entry — figured this counts as a small fix rather than a new feature. The Keys tab doesn't render this category of key at all yet (not even the existing 9), so a proper POP Keys render in the dashboard felt like its own, bigger effort and probably deserves a separate PR.
Tested locally on macOS —
fmt/clippy/test --workspaceall pass, and I confirmed live on my own POP Keys (spare caps and all) that it actually works:Happy to adjust naming or scope if you'd rather it done differently.