Skip to content

chore(gui): bump gpui-component to da4f9369 - #655

Open
AprilNEA wants to merge 2 commits into
masterfrom
chore/bump-gpui-component
Open

chore(gui): bump gpui-component to da4f9369#655
AprilNEA wants to merge 2 commits into
masterfrom
chore/bump-gpui-component

Conversation

@AprilNEA

Copy link
Copy Markdown
Owner

Summary

Moves the gpui-component pin 112 commits forward (03155566da4f9369, 2026-07-16 → 08-16) and takes zed cc053a4a with it, matching the gpui revision upstream itself builds against.

No API we use moved, so the GUI compiles unchanged. Upstream highlights we pick up:

  • the gpui-base foundation split (refactor: introduce the internal gpui-base architecture longbridge/gpui-component#2677) — reusable behavior now lives below the styled facade, which keeps re-exporting the old paths;
  • three IME fixes in the input engine, plus a panic fix for multi-line text in a single-line input;
  • scroll containers no longer leaking wheel events into their parent, and trackpad gestures locking to their starting axis;
  • menu and combobox focus-restore fixes;
  • title-bar and theme-refresh work, and Linux client-side decoration improvements.

The one breaking rename upstream made (ScrollbarShowScrollbarMode, no alias kept) is in an API this repo does not use.

Changes

  • crates/openlogi-gui: read the bundled theme set from the pinned checkout's themes/ directory instead of a hard-coded stem list. The bump broke the build outright because upstream retired the Matrix theme (chore: Fix theme refresh, popup layering, and title bar styling longbridge/gpui-component#2701); the same list had also silently omitted aurora since it landed, so it never appeared in the picker. The set is sorted, so the embedded order stays stable across machines.
  • Root Cargo.toml / Cargo.lock: gpui-component and gpui-component-assets to da4f9369; gpui (lock-only pin) to zed cc053a4a, which carries gpui_platform, gpui_macros and taffy 0.12.2 along with it.

A settings file that names the now-removed Matrix theme falls back to the OpenLogi brand theme through the existing path in apply_from_settings.

Testing

cargo fmt --all -- --check
cargo clippy --workspace --all-targets -- -D warnings
cargo test --workspace
RUSTDOCFLAGS="-D warnings" cargo doc -p openlogi-hid -p openlogi-hidpp \
  -p openlogi-hidpp-derive --no-deps --document-private-items

All green on the final tree. The app was also run against openlogi-agent-mock: the device carousel, title bar, status bar and theming render correctly after the bump.

Not verified: the Appearance page's theme grid was not opened (no click automation on this machine), so the Matrix removal and the newly bundled Aurora theme are unconfirmed visually. Not runtime-tested on hardware — this change touches no device logic. Linux and Windows were not compiled locally; no cfg-gated code changed here, but gpui and gpui_platform did move, so CI is the check for those targets.

The build script embedded a hard-coded list of upstream theme stems, so a
gpui-component bump that retires a theme breaks the build outright
(gpui-component#2701 dropped Matrix), and one that adds a theme leaves it
silently missing from the picker — aurora had been absent that way since it
landed. Read whatever the pinned checkout's themes/ directory holds instead,
sorted so the embedded order stays stable across machines.
Moves the pin 112 commits forward and takes zed cc053a4a with it, matching
the gpui revision gpui-component itself builds against.

Upstream highlights: the gpui-base foundation split (gpui-component#2677),
IME fixes in the input engine, scroll containers no longer leaking wheel
events into their parent, menu focus-restore fixes, and title-bar and
theme-refresh work. No API we use moved — the GUI compiles unchanged.

The Matrix theme is gone upstream; a settings file naming it falls back to
the OpenLogi brand theme.
Copilot AI lite review requested due to automatic review settings August 17, 2026 23:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@greptile-apps

greptile-apps Bot commented Aug 17, 2026

Copy link
Copy Markdown

Greptile Summary

The PR advances the pinned gpui-component and matching Zed/GPUI revisions, updating their transitive lockfile graph. It also replaces the hard-coded upstream theme list with deterministic discovery of all JSON themes in the pinned checkout.

  • Pins gpui-component and gpui-component-assets to da4f9369.
  • Updates the associated GPUI/Zed and transitive dependencies.
  • Discovers, sorts, and embeds all upstream theme JSON files at build time.

Confidence Score: 5/5

The PR appears safe to merge with no concrete changed-code-triggered failures identified.

The dependency pins remain synchronized, and the build script deterministically embeds the trusted upstream theme set while failing clearly when the directory is missing or empty.

Important Files Changed

Filename Overview
Cargo.toml Updates the component and asset pins together as required by their shared generated API and assets.
Cargo.lock Records the expected GPUI/Zed revision and transitive dependency changes; no changed-code-triggered advisory exploit was established.
crates/openlogi-gui/build.rs Replaces a stale fixed theme list with sorted JSON-file discovery while retaining explicit read and empty-directory failures.

Reviews (1): Last reviewed commit: "chore(gui): bump gpui-component to da4f9..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants