chore(gui): bump gpui-component to da4f9369 - #655
Open
AprilNEA wants to merge 2 commits into
Open
Conversation
The build script embedded a hard-coded list of upstream theme stems, so a gpui-component bump that retires a theme breaks the build outright (gpui-component#2701 dropped Matrix), and one that adds a theme leaves it silently missing from the picker — aurora had been absent that way since it landed. Read whatever the pinned checkout's themes/ directory holds instead, sorted so the embedded order stays stable across machines.
Moves the pin 112 commits forward and takes zed cc053a4a with it, matching the gpui revision gpui-component itself builds against. Upstream highlights: the gpui-base foundation split (gpui-component#2677), IME fixes in the input engine, scroll containers no longer leaking wheel events into their parent, menu focus-restore fixes, and title-bar and theme-refresh work. No API we use moved — the GUI compiles unchanged. The Matrix theme is gone upstream; a settings file naming it falls back to the OpenLogi brand theme.
Greptile SummaryThe PR advances the pinned gpui-component and matching Zed/GPUI revisions, updating their transitive lockfile graph. It also replaces the hard-coded upstream theme list with deterministic discovery of all JSON themes in the pinned checkout.
Confidence Score: 5/5The PR appears safe to merge with no concrete changed-code-triggered failures identified. The dependency pins remain synchronized, and the build script deterministically embeds the trusted upstream theme set while failing clearly when the directory is missing or empty.
|
| Filename | Overview |
|---|---|
| Cargo.toml | Updates the component and asset pins together as required by their shared generated API and assets. |
| Cargo.lock | Records the expected GPUI/Zed revision and transitive dependency changes; no changed-code-triggered advisory exploit was established. |
| crates/openlogi-gui/build.rs | Replaces a stale fixed theme list with sorted JSON-file discovery while retaining explicit read and empty-directory failures. |
Reviews (1): Last reviewed commit: "chore(gui): bump gpui-component to da4f9..." | Re-trigger Greptile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves the
gpui-componentpin 112 commits forward (03155566→da4f9369, 2026-07-16 → 08-16) and takes zedcc053a4awith it, matching the gpui revision upstream itself builds against.No API we use moved, so the GUI compiles unchanged. Upstream highlights we pick up:
gpui-basefoundation split (refactor: introduce the internal gpui-base architecture longbridge/gpui-component#2677) — reusable behavior now lives below the styled facade, which keeps re-exporting the old paths;The one breaking rename upstream made (
ScrollbarShow→ScrollbarMode, no alias kept) is in an API this repo does not use.Changes
crates/openlogi-gui: read the bundled theme set from the pinned checkout'sthemes/directory instead of a hard-coded stem list. The bump broke the build outright because upstream retired the Matrix theme (chore: Fix theme refresh, popup layering, and title bar styling longbridge/gpui-component#2701); the same list had also silently omittedaurorasince it landed, so it never appeared in the picker. The set is sorted, so the embedded order stays stable across machines.Cargo.toml/Cargo.lock:gpui-componentandgpui-component-assetstoda4f9369;gpui(lock-only pin) to zedcc053a4a, which carriesgpui_platform,gpui_macrosand taffy 0.12.2 along with it.A settings file that names the now-removed Matrix theme falls back to the OpenLogi brand theme through the existing path in
apply_from_settings.Testing
All green on the final tree. The app was also run against
openlogi-agent-mock: the device carousel, title bar, status bar and theming render correctly after the bump.Not verified: the Appearance page's theme grid was not opened (no click automation on this machine), so the Matrix removal and the newly bundled Aurora theme are unconfirmed visually. Not runtime-tested on hardware — this change touches no device logic. Linux and Windows were not compiled locally; no cfg-gated code changed here, but gpui and gpui_platform did move, so CI is the check for those targets.