feat: wheel tilt-left/right as bindable buttons (verified on MX Ergo) - #357
feat: wheel tilt-left/right as bindable buttons (verified on MX Ergo)#357g30r93g wants to merge 6 commits into
Conversation
Greptile SummaryThis PR adds wheel tilt-left and tilt-right as bindable mouse controls.
Confidence Score: 5/5This looks safe to merge.
|
| Filename | Overview |
|---|---|
| crates/openlogi-hid/src/gesture.rs | Adds tilt CID diversion, restoration, and rising-edge capture for tilt button presses. |
| crates/openlogi-agent-core/src/watchers/gesture.rs | Adds tilt arming based on non-default tilt bindings and passes that state into capture sessions. |
| crates/openlogi-core/src/binding.rs | Adds tilt button IDs, labels, ordering, and default horizontal-scroll actions. |
| crates/openlogi-gui/src/mouse_model/geometry.rs | Maps scroll-left and scroll-right asset slots to the new tilt controls. |
Reviews (2): Last reviewed commit: "docs(tilt): note wheel-tilt buttons in c..." | Re-trigger Greptile
Address code-review: the module docs mentioned wheel tilt but the CapturedInput::ButtonPressed variant doc, the agent-core watcher module doc, and the ButtonId doc still described the pre-tilt set. Also clarify that ButtonId variants are appended (TOML-stable) while ButtonId::ALL carries the physical layout order.
a8d9ff4 to
d58ddbb
Compare
|
Confirming the premise from an MX Ergo's own
Cross-reference: #359 targets the same two controls from the OS hook side by intercepting horizontal scroll rather than diverting the CID. Can test against two MX Ergo units, Unifying and Bluetooth, once #367 is unblocked. |
|
Thanks for working on this. I am testing wheel-tilt remapping with an MX Anywhere 2S on Windows and wanted to share some device-specific follow-up. For this device:
This looks like a good fit for this PR's HID++ diversion approach, rather than generic horizontal-scroll interception, because the HID++ controls provide the exact tilt direction and avoid confusing tilt with thumbwheel input. Could this PR be rebased onto the current master and extended with the MX Anywhere 2S metadata names and held-volume behavior? |
What
Adds the scroll-wheel tilt-left / tilt-right controls as first-class bindable buttons. These horizontal-tilt controls (HID++
0x1b04reprogrammable controls, CIDs0x5b/0x5d) weren't detected or configurable before; they now appear on the mouse diagram with an action picker and default to horizontal scroll.Addresses #100 (wheel tilt not detected / not configurable). That issue is filed against the M500S; this implements the general mechanism and is verified end-to-end on an MX Ergo (same standard Logitech tilt CIDs). I don't have an M500S to confirm, but the capture path and slot-name mapping are device-agnostic.
How (mirrors existing patterns)
ButtonId::TiltLeft/TiltRight(appended, TOML-stable), default-bound toHorizontalScrollLeft/HorizontalScrollRight.thumbwheel_armed), so native horizontal scrolling is untouched otherwise.SLOT_NAME_SCROLL_LEFT/SLOT_NAME_SCROLL_RIGHT— no asset-registry change.Verification
cargo fmt --check,cargo clippy --workspace -D warnings, andcargo test --workspace(417 passed, 0 failed) all green.tilt_armedgating, and the slot-name mapping.diag controlsreports0x5b/0x5dasdivertable, and a live capture session recorded 142 physical tilt events correctly mapped toTiltLeft/TiltRight(not swapped).Not in scope
0xd7).