Conversation
Fix macOS runtime packaging and ship Codex 0.154.0 in build6
Host recompute can early-return and queue a GUI follow-up while cooperative/pending/presentation gates are active. Stay on the document thread, pump Qt, and hard-fail with RECOMPUTE_DRAIN_TIMEOUT instead of returning stale geometry as success. Co-authored-by: Jason <[email protected]>
Member
Author
|
Live Windows retest passed on this branch: fem_bracket HTTP false-burst then |
Gates-clear plus Up-to-date is not enough after open: patterned PartDesign tips can hold a stable but incomplete solid, and a later idle recompute is a no-op. After flags go idle, sample Tip/Body Shape signatures, re-issue if volume is still moving or Tip disagrees with Body, and force one rebuild for patterned tips. Co-authored-by: Jason <[email protected]>
Live propeller probes: idle recompute and document.recompute(force) are no-ops on an Up-to-date PolarPattern. touch(Tip)+touch(Pad) (or re-assigning the same Length) then recompute repairs the incomplete solid. After the primary drain, dirty those features and rebuild until Volume is stable across that pass. Co-authored-by: Jason <[email protected]>
3 tasks
Member
Author
|
Closing as superseded by the upstream PR into 10-X-eng main: 10-X-eng#246 (Fixes 10-X-eng#245). Same branch lineage ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
/v1/runasks forrecompute:true,run_scriptstays on the document thread until rebuild is actually finished (or hard-fails). Default is stillrecompute:true.recompute:falseis unchanged.What changed
After the host
document.recompute():Touched.openDocument. Live probes: idlerecompute:true, in-scriptdoc.recompute()twice, and pollingShape.Volumedo not change a wrong solid.pad.touch()+tip.touch()or re-assigning the same Length, then recompute, does.Originals/BaseFeature, and objects that were Touched at the start of the call, then rebuilds.RECOMPUTE_DRAIN_TIMEOUT).document.recompute(..., True)is not used as the extra pass:forceonly bypassesSkipRecompute; it does not execute Up-to-date features.Verify
Result:
140 passed, 1 skipped in 4.68sResult:
22 passed in 0.16sLive propeller first-after-open remains a manual check on the Windows GUI host.
Remaining risk
Compatibility
recomputestill defaults to true).Refs #5