Repository navigation
Remove retired custom domain from routing and rollback configuration - #9
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the retired custom-domain route completely: wrangler.jsonc now has routes: [], with workers_dev: true and preview_urls: false. Update the regression assertion and remove staging/rollback instructions that would recreate the retired hostname. Preserve the Worker, D1, cron, secrets, merge gate and immutable review pin.
The owner explicitly authorized live domain removal after #8: the exact Worker custom-domain binding was detached using the existing Wrangler CLI OAuth authentication and the documented Cloudflare API, without MCP or a Worker code deployment. The pinned Wrangler CLI has no standalone custom-domain delete command and skips an empty custom-domain list, so removing the config entry alone was insufficient. Read-back verified no Worker domain binding; both authoritative Cloudflare nameservers returned NXDOMAIN for A and AAAA queries. No zone protection settings were modified.
Validation: npm run check passed 130 tests, typecheck/lint/build; Wrangler deployment dry-run passed; git diff --check passed. No retired hostname literal remains in tracked source. No secrets, GitHub App settings, workflow pins, merges or code deployments changed.
At removal the Workers.dev endpoint was still disabled and live PUBLIC_URL had not yet been migrated. The backend therefore requires a separately authorized deployment of this reviewed configuration, coordinated App/caller changes, fresh ChatGPT connection and credential-only acceptance. Do not restore the deleted domain as rollback or deploy a configuration that reintroduces it. See docs/origin-migration.md. This is a follow-up because #8 was merged while the deletion was being prepared.