Skip to content

Fix isolated review admission, durable progress and trusted image caching - #5

Merged
AppSolves merged 2 commits into
mainfrom
feat/review-recovery-progress-cache
Nov 14, 2026
Merged

AppSolves merged 2 commits into
mainfrom
feat/review-recovery-progress-cache

Conversation

@AppSolves

@AppSolves AppSolves commented Nov 14, 2026 •

Copy link
Copy Markdown
Owner

A called review workflow could receive empty credential inputs despite a configured protected Environment, then lose the original broker error and leave the request without a terminal status. Declare named secret grants in generated callers, fail early on missing/ambiguous credentials, preserve sanitized stage/code/status diagnostics and recover only workload-bound requests and session leases. A separate administrator-only read-only OIDC check never admits a manual run to the credential broker.

Adds one App-owned progress comment with verified PR counts, request/run/review identity, leased updates, bounded retries and reconciliation of ambiguous POST responses. Failed workflow output remains permanently non-approving. Existing native inline reviews and publisher isolation remain intact. New setup uses a repository-specific CBReview textual alias; existing configured triggers remain compatible.

The trusted Docker build optionally uses pinned Buildx/GHA caching and executes by content ID. Cache stays disabled by default pending the included no-provider benchmark: import/export overhead may exceed the original short build.

Validation: Node 24 typecheck/lint/build and 124 tests; clean-source npm ci/check; actual workerd/D1; actionlint; Docker build and sandbox; npm audit (zero vulnerabilities); strict image scan (zero HIGH/CRITICAL); source secret scan and diff check. No real provider inference or paid fallback.

Rollout requires additive D1 migration 0003 and coordinated caller/Worker TRUSTED_WORKFLOW pins to the actual merged commit. Preserve the hosted OAuth gate and keep automatic merging disabled. See docs/review-rollout.md for exact recovery and acceptance limits. GitHub CI passed on the final feature commit. The no-provider benchmark measured 14s ordinary / 49s cold cache / 14s restored cache; cache stays off. Production read-back and real inference remain separate acceptance steps.

@AppSolves
AppSolves merged commit 4ed6688 into main Nov 14, 2026
4 checks passed
@AppSolves
AppSolves deleted the feat/review-recovery-progress-cache branch November 14, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant