Repository navigation
fix: preserve incomplete reviews and orchestrate bounded coverage - #47
Merged
Merged
Conversation
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid incomplete model reviews previously aborted the isolated engine before the trusted host could retain their summary/findings. Preserve those validated partial results while keeping the review job failed and publication strictly COMMENT. Invalid, quarantined, wrongly scoped or unverifiable outputs cannot approve or merge. Preserve primary execution/proxy failures and earlier safe findings when later work fails.
The trusted host creates immutable evidence groups (16 files / 2 MB, at most 32), retains all shared read-only source/dependencies and binds results to original units and input hashes. One pinned Codex thread executes the groups with at most two targeted continuations globally. Multiple groups require a separate cross-group synthesis; a sole group integrates the explicit final whole-PR check into its own response, eliminating a redundant model turn. The outer host independently validates coverage/attempts/synthesis and rechecks drained context and output completeness. Missing required evidence cannot be waived. Findings retain original source locations, are deduplicated and cannot be silently removed by synthesis; output loss prevents approval.
Final hardening:
Budget/security contract: one proxy and one 20-minute timer for all work; the existing 100 inference-request, 24 context-lookup and 768 GitHub-call limits are not reset or increased. A one-group native scripted inspection/report uses one turn/two requests. The six-group fixture uses seven baseline turns/14 scripted requests, or eight/16 with its one continuation. Actual model tool use, retries, latency and tokens can be substantially higher. The maximum 32-group plan can require 35 turns with continuation, leaving limited request/time headroom; no universal large-PR completion guarantee is claimed. Runtime arithmetic and remaining compaction/re-encoding uncertainty are documented in docs/adaptive-context.md.
Validation (Node 24):
npm run check: typecheck, lint, all 242 tests and build passed.npm run test:clean: independentnpm ci --ignore-scripts/ full check with regenerated Env passed.npm run test:workers,npm run test:web,npm run catalog:check: passed.npm run test:sandbox: actual pinned Codex 0.169.0, real inspection/isolation and 14 scripted-provider scenarios passed, including distinct images, continuation, failed synthesis, evidence tampering, shared-budget exhaustion and cross-group findings. No live AI inference.npm audit --audit-level=moderate: zero vulnerabilities; Actionlint, Wrangler dry-run and diff checks passed.Authentication, isolation, Git/OIDC integrity, credentials, quotas, merge policy and production data are unchanged. The opt-in provider harness understands the private execution envelope and still requires explicit live/paid authorization and an explicit bounded allowance. No Worker trust/configuration pin or downstream caller was changed. No merge, deployment, live inference or release is part of this task. Real-model semantic quality, latency/token consumption and large-history compaction behavior remain controlled live acceptance items; a later authorized rollout must coordinate the actual source merge SHA normally and begin with observed advisory/no-merge reviews.
GitHub CI for exact head 79e2d26: push run https://github.com/AppSolves/codexbot/actions/runs/43771068065 and pull-request run https://github.com/AppSolves/codexbot/actions/runs/43771071268 both completed successfully, including sandbox and Trivy security checks. PR remains open; no auto-merge, deployment or caller changes.