Repository navigation
fix: verified PNG vision and bounded large-PR context - #38
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing GitHub text patches for valid PNGs previously made an otherwise reviewable PR incomplete before inference. This change verifies immutable PNG blobs separately, supplies base/head images through Codex 0.169.0 localImage inputs, and preserves fail-closed behavior for missing textual evidence, unsupported binaries and incomplete visual analysis. Image findings use summary locations rather than invented inline lines.
Context collection prioritizes changed files and trusted instructions, caches immutable Git objects, and enforces explicit large-PR byte, file, call and time budgets. Protected repository policy may opt individual daily review quotas into
unlimited; authorization, concurrency, cooldown, duplicate protection and provider allowance remain enforced.Validation: 208 unit/integration tests via
npm run check; fresh-checkout install/check; real workerd/D1; browser suite; pinned catalog; npm audit (zero vulnerabilities); Actionlint; Wrangler dry-run; Docker build and actual pinned Codex sandbox tests, including image transport and invalid-image rejection. Scripted Responses test execution and isolation, not live-model visual understanding. No new provider inference was launched.Rollout: this PR deliberately closes the deployment merge gate. After normal protected merge, deploy maintenance with the existing trust pin, reconcile active merge intents, coordinate the actual merged SHA across Worker/tests and active callers, verify the cutover, then restore the reviewed merge gate. No migration, credential change, browser-OAuth activation or release version bump is required.